Fix timepicker close #5341
Merged
Fix timepicker close #5341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desvelao
reviewed
Mar 30, 2023
Wazuh dashboardLegend: UI
Details 🟢 The timepicker selector in the Evolution panel of the Agent section should close it when it is opened and the button is clickedChrome - 🟢 Firefox - 🟢 |
Machi3mfl
previously approved these changes
Mar 30, 2023
There was a problem hiding this comment.
Wazuh dashboard
Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
UI
| Test | Chrome | Firefox |
|---|---|---|
| The timepicker selector in the Evolution panel of the Agent section should close it when it is opened and the button is clicked | 🟢 | 🟢 |
Details
🟢 The timepicker selector in the Evolution panel of the Agent section should close it when it is opened and the button is clicked
Chrome - 🟢
Kazam_screencast_00013.mp4
Firefox - 🟢
Kazam_screencast_00014.mp4
Desvelao
approved these changes
Mar 30, 2023
|
Machi3mfl
approved these changes
Mar 30, 2023
Machi3mfl
deleted the
fix-5300-agents-evolution-time-picker-does-not-close
branch
github-actions bot
pushed a commit
that referenced
this pull request
Mar 30, 2023
* Fix timepicker close * Add changelog * Update CHANGELOG.md (cherry picked from commit a24a1b7)
github-actions bot
pushed a commit
that referenced
this pull request
Mar 30, 2023
* Fix timepicker close * Add changelog * Update CHANGELOG.md (cherry picked from commit a24a1b7)
Machi3mfl
pushed a commit
that referenced
this pull request
Mar 30, 2023
Fix timepicker close (#5341) * Fix timepicker close * Add changelog * Update CHANGELOG.md (cherry picked from commit a24a1b7) Co-authored-by: Ian Yenien Serrano <[email protected]>
Tostti
pushed a commit
that referenced
this pull request
Mar 30, 2023
Fix timepicker close (#5341) * Fix timepicker close * Add changelog * Update CHANGELOG.md (cherry picked from commit a24a1b7) Co-authored-by: Ian Yenien Serrano <[email protected]>
3 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the problem that did not allow closing the time picker when the button was clicked again.
The scrolling of the menu when opening the timepicker is specific to EuiPopover as it is happening in all EuiPopovers.
Issues Resolved
Evidence
At the beginning you can see how the timepicker works and at the end you can see that the EuiPopover have the same behaviour.
Peek.2023-03-30.15-44.mp4
Test
Check List
yarn test:jest