Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IT FIM: Refactor 'test_registry' according to new standard (4) #2353

Closed
damarisg opened this issue Dec 17, 2021 · 1 comment · Fixed by #2478
Closed

IT FIM: Refactor 'test_registry' according to new standard (4) #2353

damarisg opened this issue Dec 17, 2021 · 1 comment · Fixed by #2478
Assignees
Labels
feature/fim refactor Redesign and implement an existing development/feature

Comments

@damarisg
Copy link
Member

damarisg commented Dec 17, 2021

It is necessary to have a new standard in the tests, this will help to improve their modularization, along with the execution times.

This issue aims to refactor:

  • test_registry/test_registry_file_limit/test_registry_limit_values.py
  • test_registry/test_registry_file_limit/test_registry_limit_capacity_alerts.py
  • test_registry/test_registry_file_limit/test_registry_limit_full.py
  • test_registry/test_registry_report_changes/test_registry_diff_size_limit_values.py
  • test_registry/test_registry_report_changes/test_registry_all_limits_disabled.py
  • test_registry/test_registry_report_changes/test_registry_file_size_values.py
  • test_registry/test_registry_report_changes/test_registry_disk_quota_values.py
@damarisg damarisg added team/qa refactor Redesign and implement an existing development/feature feature/fim labels Dec 17, 2021
@damarisg damarisg changed the title Refactor limits tests of 'test_registry' folder with the new standard Refactor FIM 'test_registry' according to new standard (4) Dec 20, 2021
@Deblintrake09
Copy link
Contributor

Deblintrake09 commented Jan 10, 2022

Update on Work 24/01/2022 - 25/01/2022

  • Finished Refactoring tests
  • manual testing for test_file_limit and disk_quota
  • Sync with Core Watchdogs team on how test_registry_disk_quota_values is designed and the functionality of disk_quota_values
  • Reorganize test_report_changes folder, to create folders for test_file and for disk_quota

Update on Work done During Sprint 5 19/01/2022 - 20/01/2022

  • Completed refactor on registry_value_cud into 3 functions (registry_value_create, registry_value_update, registry_value_delete) for greater test modularity.
  • Refactored test_registry/test_registry_report_changes/test_registry_all_limits_disabled.py unblocked test and refactored with new functions. improved time as well.

Update on Work done During Sprint 5 10/01/2022 - 11/01/2022

  • worked on test_registr_limit tests:
  • test_registry_limit_values.py - 🔴 - Working
  • test_registry_limit_capacity_alerts.py - fixed 🟢
  • test_registry_limit_full.py - removed skip 🔴 - fixed 🟢

Update Work done on Issue During Sprint 4 27/12/2021 - 07/01/2022

  • Research on tests
  • Initial refactor of All tests (Remove hard-coded variables, callbacks and error messages. clean up tests and formatting)
  • Test failed on local instances (Possibly linked to Issue #2421. On Jenkins they are not run since they are scheduled tests.
  • Research on fixing test_registry_report_changes tests. A Full rewrite is suggested, dividing each test into different stages.

Test Status at the start of research

  • test_registry_limit_values.py 🔴
  • test_registry_limit_capacity_alerts.py 🟢
  • test_registry_limit_full.py - Skipped Issue # 1602
  • test_registry_diff_size_limit_values.py 🔴
  • test_registry_all_limits_disabled.py - Skipped Issue # 1602
  • test_registry_file_size_values.py 🔴
  • test_registry_disk_quota_values.py 🔴

Folder Results: Registry_Report_Changes.zip

@Deblintrake09 Deblintrake09 linked a pull request Jan 25, 2022 that will close this issue
5 tasks
@damarisg damarisg changed the title Refactor FIM 'test_registry' according to new standard (4) IT FIM: Refactor 'test_registry' according to new standard (4) Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/fim refactor Redesign and implement an existing development/feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants