Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor of the testing framework for vulnerability_detector #2462

Closed
5 tasks done
jmv74211 opened this issue Jan 21, 2022 · 0 comments · Fixed by #2499
Closed
5 tasks done

Refactor of the testing framework for vulnerability_detector #2462

jmv74211 opened this issue Jan 21, 2022 · 0 comments · Fixed by #2499
Assignees
@jmv74211
Labels
feature/vuln-detector refactor Redesign and implement an existing development/feature

Comments

@jmv74211
Copy link
Contributor

jmv74211 commented Jan 21, 2022 •
edited
Loading

Refactoring the testing framework for vulnerability_detector

So far, the module structure of the QA framework for vulnerability detector is quite simple and messy. Basically everything used for vulnerability detector testing is located in the vulnerability_detector.py module without taking into account that much of that functionality is duplicated or can be used by other different modules.

A refactor of the testing framework for vulnerability detector is requested, designing a reusable organization separated by functionalities.

After such a rework, the same results should be obtained in all related testing as at the beginning.

Tasks

  • Perform modular and reusable design.
  • Review used functions and refactor them.
  • Distribute functions in the new modules.
  • Update all the code that uses the modified testing framework.
  • Test that all tests involved work correctly (using the modified testing framework).
@jmv74211 jmv74211 added team/qa refactor Redesign and implement an existing development/feature test/integration feature/vuln-detector labels Jan 21, 2022
@jmv74211 jmv74211 mentioned this issue Jan 21, 2022
Closed
8 tasks
@jmv74211 jmv74211 self-assigned this Jan 21, 2022
@jmv74211 jmv74211 changed the title Vulnerability detector test module refactor: test_providers_enabled Refactoring the testing framework for vulnerability_detector Jan 24, 2022
@jmv74211 jmv74211 changed the title Refactoring the testing framework for vulnerability_detector Refactor of the testing framework for vulnerability_detector Jan 24, 2022
jmv74211 added a commit that referenced this issue Jan 24, 2022
@jmv74211
add: Add sqlite tools module #2462
a0cb3ef
jmv74211 added a commit that referenced this issue Jan 24, 2022
@jmv74211
refac: Update sqlite usages in vulnerability detector lib module #2462
9ff90ac
jmv74211 added a commit that referenced this issue Jan 24, 2022
@jmv74211
refac: Split vuln modules variables in a new module #2462
1a437c6
jmv74211 added a commit that referenced this issue Jan 24, 2022
@jmv74211
add: Add callbacks module to the vuln detector lib #2462
d613a94
jmv74211 added a commit that referenced this issue Jan 24, 2022
@jmv74211
refac: Move query functions from vuln module to the db_interface module
9b60358 
#2462
jmv74211 added a commit that referenced this issue Jan 24, 2022
@jmv74211
refac: Improve db_interface module from vuln detector #2462
776133b
jmv74211 added a commit that referenced this issue Jan 24, 2022
@jmv74211
add: Add WAZUH_PATH variable to wazuh_testing module #2462
575f0a7
jmv74211 added a commit that referenced this issue Jan 24, 2022
@jmv74211
add: Add db_interface module to the wazuh_testing framework #2462
57a15d2
jmv74211 added a commit that referenced this issue Jan 24, 2022
@jmv74211
rm: Remove sqlite and db_interface modules #2462
71b357a
jmv74211 added a commit that referenced this issue Jan 24, 2022
@jmv74211
add: Add generic db_interface module #2462
25bf36a
jmv74211 added a commit that referenced this issue Jan 24, 2022
@jmv74211
add: Add new global variables to wazuh_testing generic module #2462
c729a0d
jmv74211 added a commit that referenced this issue Jan 24, 2022
@jmv74211
add: Add db interface modules #2462:
385d380 
- agent_db
- cve_db
- global_db
jmv74211 added a commit that referenced this issue Jan 24, 2022
@jmv74211
add: Add client_keys tools module #2462
2bda735
jmv74211 added a commit that referenced this issue Jan 24, 2022
@jmv74211
add: Add mocking module to wazuh_testing framework #2462
c0b0a77
fedepacher added a commit that referenced this issue Jan 24, 2022
@fedepacher
doc: Add documentation to new vuln detector methods #2462
0af524e
jmv74211 added a commit that referenced this issue Jan 24, 2022
@jmv74211
add: Add new method to agent_db module #2462
45ab0fb
jmv74211 added a commit that referenced this issue Jan 24, 2022
@jmv74211
add: Add event_monitor module to vuln detector #2462
1e7770b
jmv74211 added a commit that referenced this issue Jan 24, 2022
@jmv74211
add: Add processes module to the wazuh_testing framework #2462
91d9bc7
jmv74211 added a commit that referenced this issue Jan 24, 2022
@jmv74211
add: Add utils module to the vuln detector testing framework #2462
0a325b9
jmv74211 added a commit that referenced this issue Jan 24, 2022
@jmv74211
rm: Remove vulnerability detector module #2462
c2381a8
jmv74211 added a commit that referenced this issue Jan 25, 2022
@jmv74211
style: Apply PEP-8 style to some modules #2462
65e0cb1
jmv74211 added a commit that referenced this issue Jan 25, 2022
@jmv74211
refac: Update the vulnerability detector module import #2462
d2c0f12
@jmv74211 jmv74211 mentioned this issue Jan 25, 2022
Merged
1 task
jmv74211 added a commit that referenced this issue Jan 27, 2022
@jmv74211
add: Add sqlite tools module #2462
9ef35a4
jmv74211 added a commit that referenced this issue Jan 27, 2022
@jmv74211
refac: Update sqlite usages in vulnerability detector lib module #2462
5301946
jmv74211 added a commit that referenced this issue Jan 27, 2022
@jmv74211
refac: Split vuln modules variables in a new module #2462
22c829e
jmv74211 added a commit that referenced this issue Jan 27, 2022
@jmv74211
add: Add callbacks module to the vuln detector lib #2462
5ef57db
jmv74211 added a commit that referenced this issue Jan 27, 2022
@jmv74211
refac: Move query functions from vuln module to the db_interface module
a1e1c92 
#2462
jmv74211 added a commit that referenced this issue Jan 27, 2022
@jmv74211
refac: Improve db_interface module from vuln detector #2462
7731ea5
jmv74211 added a commit that referenced this issue Jan 27, 2022
@jmv74211
add: Add WAZUH_PATH variable to wazuh_testing module #2462
40ccb6f
jmv74211 added a commit that referenced this issue Jan 27, 2022
@jmv74211
add: Add db_interface module to the wazuh_testing framework #2462
644394b
jmv74211 added a commit that referenced this issue Jan 27, 2022
@jmv74211
rm: Remove sqlite and db_interface modules #2462
165f564
jmv74211 added a commit that referenced this issue Jan 27, 2022
@jmv74211
add: Add generic db_interface module #2462
8780647
jmv74211 added a commit that referenced this issue Jan 27, 2022
@jmv74211
add: Add new global variables to wazuh_testing generic module #2462
ecc11b9
jmv74211 added a commit that referenced this issue Jan 27, 2022
@jmv74211
add: Add db interface modules #2462:
88067b5 
- agent_db
- cve_db
- global_db
jmv74211 added a commit that referenced this issue Jan 27, 2022
@jmv74211
add: Add client_keys tools module #2462
d43ac07
jmv74211 added a commit that referenced this issue Jan 27, 2022
@jmv74211
add: Add mocking module to wazuh_testing framework #2462
ecef19e
jmv74211 pushed a commit that referenced this issue Jan 27, 2022
@fedepacher @jmv74211
doc: Add documentation to new vuln detector methods #2462
6ee0652
jmv74211 added a commit that referenced this issue Jan 27, 2022
@jmv74211
add: Add new method to agent_db module #2462
25cbcf3
jmv74211 added a commit that referenced this issue Jan 27, 2022
@jmv74211
add: Add event_monitor module to vuln detector #2462
a16df41
jmv74211 added a commit that referenced this issue Jan 27, 2022
@jmv74211
add: Add processes module to the wazuh_testing framework #2462
e6645e1
jmv74211 added a commit that referenced this issue Jan 27, 2022
@jmv74211
add: Add utils module to the vuln detector testing framework #2462
9153c31
jmv74211 added a commit that referenced this issue Jan 27, 2022
@jmv74211
rm: Remove vulnerability detector module #2462
adc023a
jmv74211 added a commit that referenced this issue Jan 27, 2022
@jmv74211
refac: Apply new refactor changes to some basic vuln detector tests #…
6129566 
…2462
jmv74211 added a commit that referenced this issue Jan 27, 2022
@jmv74211
refac: Apply new refactor changes to vuln detector tests #2462
48c9a4d 
- test_validate_feed_content
- test_general_settings_retry_interval
- test_full_scan_type
jmv74211 added a commit that referenced this issue Jan 27, 2022
@jmv74211
style: Apply PEP-8 style to some modules #2462
6c37f73
jmv74211 added a commit that referenced this issue Jan 27, 2022
@jmv74211
refac: Update the vulnerability detector module import #2462
a0ee5ce
@jmv74211 jmv74211 mentioned this issue Jan 27, 2022
Merged
1 task
@CamiRomero CamiRomero mentioned this issue Apr 20, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmv74211 jmv74211

Labels
feature/vuln-detector refactor Redesign and implement an existing development/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor of the testing framework for vulnerability_detector wazuh/wazuh-qa
1 participant
@jmv74211