Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt tests to new EPS logs #3559

Closed
QU3B1M opened this issue Nov 3, 2022 · 1 comment · Fixed by #3564
Closed

Adapt tests to new EPS logs #3559

QU3B1M opened this issue Nov 3, 2022 · 1 comment · Fixed by #3564
Assignees

Comments

@QU3B1M
Copy link
Member

QU3B1M commented Nov 3, 2022

Target version Related issue Related PR
4.4 #15188 #15278

Description

The analysisd EPS tests should be adapted to the modification that reduce the amount of warnings that are raised when a wazuh-manager with EPS block enabled has no <maximum> tag.

Code modification for the new log

image

Tests that are validating the EPS logs

Current behavior

The tests are only expecting one kind of log to show up.

Expected behavior

Now we have two different logs that could be raised in the ossec.log, one will be raised when the EPS is disabled (Info that already exists) and the other is a warning that appears when the <maximum> tag does not exists.

@QU3B1M
Copy link
Member Author

QU3B1M commented Nov 4, 2022

Development

A function is added to the analysisd event_monitor to handle the new WARNING log, also the analysisd integration tests test_limit_eps were updated to use this function properly expect the correspondent log
image

This changes were applied in the PR #3564, it already passed all the checks, it is in Pending Review status by now.

@jmv74211 jmv74211 added this to the Development 4.4 milestone Nov 7, 2022
@damarisg damarisg closed this as completed Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants