Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test_sync_agent_groups_get.py #3890

Closed
QU3B1M opened this issue Feb 3, 2023 · 2 comments · Fixed by #3895
Closed

Fix test_sync_agent_groups_get.py #3890

QU3B1M opened this issue Feb 3, 2023 · 2 comments · Fixed by #3895
Assignees
@QU3B1M

Comments

@QU3B1M
Copy link
Member

QU3B1M commented Feb 3, 2023

Target version Related issue Related PR
4.4.0 #15966 #16049

Description

A improvement in the calculation of the groups_hash was applied that make our tests integration/test_wazuh_db/test_sync_agent_groups_get.py fail, after doing some research it was found that the test has a hardcoded hash that is compared to the one received from wazuh.
@QU3B1M QU3B1M self-assigned this Feb 3, 2023
@QU3B1M QU3B1M mentioned this issue Feb 3, 2023
Closed
QU3B1M added a commit that referenced this issue Feb 3, 2023
@QU3B1M
fix(#3890): add func to calculate the hash correctly
185364c
@QU3B1M QU3B1M mentioned this issue Feb 3, 2023
Closed
5 tasks
@QU3B1M
Copy link
Member Author

QU3B1M commented Feb 3, 2023 •
edited
Loading

Update 03/02/2023

  • A possible fix was made in the branch 3890-fix-wazuhdb-sync-agent-groups, it still a work in progress.
  • Fix tested, everything works as expected, code updated with styling fixes.

QU3B1M added a commit that referenced this issue Feb 3, 2023
@QU3B1M
feat(#3890): add func to get the hash in wazuh_db module
24216ae
@QU3B1M QU3B1M mentioned this issue Feb 3, 2023
Merged
QU3B1M added a commit that referenced this issue Feb 3, 2023
@QU3B1M
docs(#3890): update changelog
379ccd5
QU3B1M added a commit that referenced this issue Feb 3, 2023
@QU3B1M
style(#3890): improve styling
f4e3999
QU3B1M added a commit that referenced this issue Feb 3, 2023
@QU3B1M
style(#3890): improve styling.
f362438
QU3B1M added a commit that referenced this issue Feb 3, 2023
@QU3B1M
style(#3890): improve styling
cf6d5ad
@QU3B1M
Copy link
Member Author

QU3B1M commented Feb 3, 2023

PR ready for review

After validating the fix works correctly, the PR is created and ready for review:

@QU3B1M QU3B1M linked a pull request Feb 3, 2023 that will close this issue
fix test_sync_agent_groups_get and add function to calculate hash #3895
Merged
jmv74211 pushed a commit that referenced this issue Feb 7, 2023
@QU3B1M
fix(#3890): fix agent-groups hash calculation
401c57d 
* fix(#3890): add func to calculate the hash correctly

* feat(#3890): add func to get the hash in wazuh_db module

* docs(#3890): update changelog

* style(#3890): improve styling
@QU3B1M QU3B1M closed this as completed Feb 7, 2023
@jmv74211 jmv74211 modified the milestone: 3881 Feb 9, 2023
@juliamagan juliamagan mentioned this issue Feb 9, 2023
Merged
Deblintrake09 pushed a commit that referenced this issue Apr 24, 2023
@QU3B1M @Deblintrake09
fix(#3890): fix agent-groups hash calculation
565c9e0 
* fix(#3890): add func to calculate the hash correctly

* feat(#3890): add func to get the hash in wazuh_db module

* docs(#3890): update changelog

* style(#3890): improve styling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@QU3B1M QU3B1M

Labels
None yet
Projects
No open projects
Release 4.4.0
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix test_sync_agent_groups_get and add function to calculate hash wazuh/wazuh-qa
2 participants
@jmv74211 @QU3B1M