Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed test_execd yaml due to an error in AR configuration, added do… #1080

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

jotacarma90
Copy link
Member

@jotacarma90 jotacarma90 commented Feb 22, 2021

…cumentation for this tests

Related issue
#1060

Description

This PR solves an error in Active Response configuration due to yaml AR section:

- tags:
  - all
  apply_to_modules:
  - test_execd_restart
  - test_execd_firewall_drop
  - conftest
  sections:
  - section: client
    elements:
    - notify_time:
        value: 10
    - time-reconnect:
        value: 60
    - auto_restart:
        value: 'yes'
    - crypto_method:
        value: 'aes'
    - server:
        elements:
        - address:
            value: SERVER_ADDRESS
        - port:
            value: REMOTED_PORT
        - protocol:
            value: PROTOCOL
  - section: active-response
    attributes:
      - name: 'active-response'
    elements:
    - disabled:
        value: 'no'

Logs example

Error due to a bad configuration:
2021/02/12 09:02:30 wazuh-execd: INFO: (1350): Active response disabled.

Tests

  • Proven that tests pass when they have to pass.
  • Proven that tests fail when they have to fail.

@jotacarma90 jotacarma90 self-assigned this Feb 22, 2021
@jotacarma90 jotacarma90 linked an issue Feb 22, 2021 that may be closed by this pull request
Copy link
Contributor

@Molter73 Molter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

spothound
spothound approved these changes Feb 25, 2021
@vikman90 vikman90 merged commit f9f79fb into master Feb 25, 2021
@vikman90 vikman90 deleted the 1060-test-execd-yaml-error branch February 25, 2021 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test active response problems with the yaml configuration
5 participants