Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename sockets directory according to the product #1090

Merged
merged 1 commit into from
Feb 26, 2021
Merged

Rename sockets directory according to the product #1090

merged 1 commit into from
Feb 26, 2021

Conversation

chemamartinez
Copy link
Contributor

@chemamartinez chemamartinez commented Feb 26, 2021 •
edited
Loading

Related issue
wazuh/wazuh#6885

Description

This pull request renames the sockets directory according to the issue wazuh/wazuh#6885.

  • Old sockets directory: queue/ossec
  • New sockets directory: queue/sockets

Configuration options

N/A

Logs example

N/A

Tests

  • Proven that tests pass when they have to pass.
  • Proven that tests working with sockets pass

@chemamartinez chemamartinez self-assigned this Feb 26, 2021
danimegar
danimegar approved these changes Feb 26, 2021
View reviewed changes
Copy link
Contributor

@danimegar danimegar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Molter73
Molter73 reviewed Feb 26, 2021
View reviewed changes
Copy link
Contributor

@Molter73 Molter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we may have missed this path:

wazuh-qa/deps/wazuh_testing/wazuh_testing/tools/__init__.py

Line 81 in e053a13

QUEUE_SOCKETS_PATH = os.path.join(WAZUH_PATH, 'queue', 'sockets')

Other than that, the PR LGTM.

Molter73
Molter73 approved these changes Feb 26, 2021
View reviewed changes
Copy link
Contributor

@Molter73 Molter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm blind, nevermind my previous comment. LGTM!

@chemamartinez chemamartinez merged commit bdf4606 into master Feb 26, 2021
@chemamartinez chemamartinez deleted the fix-sockets-path branch February 26, 2021 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Molter73 Molter73 Molter73 approved these changes

@danimegar danimegar danimegar approved these changes

@BraulioV BraulioV Awaiting requested review from BraulioV

Assignees

@chemamartinez chemamartinez

Labels
None yet
Projects
None yet
Milestone
Sprint 125 - Core/Kernel Ponies
Development

Successfully merging this pull request may close these issues.
3 participants
@chemamartinez @Molter73 @danimegar