Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding new tests for Wazuh-DB insert commands in agents' CVEs table #1092

Merged
merged 1 commit into from
Feb 26, 2021
Merged

Adding new tests for Wazuh-DB insert commands in agents' CVEs table #1092

merged 1 commit into from
Feb 26, 2021

Conversation

palaciosjeremias
Copy link
Contributor

Related issue
1069

Description

This PR adds test cases for the following vuln_cve insert commands:

  • Insert command with a paylod that contains white space (to validate a fix in the parsing of vuln_cve commands)
  • Insert command without payload.

Tests

  • Proven that tests pass when they have to pass.
  • Proven that tests fail when they have to fail.

@palaciosjeremias palaciosjeremias self-assigned this Feb 26, 2021
@palaciosjeremias palaciosjeremias changed the title Add test cases for vuln_cve insert command Adding new tests for Wazuh-DB insert commands in agents' CVEs table Feb 26, 2021
@palaciosjeremias palaciosjeremias linked an issue Feb 26, 2021 that may be closed by this pull request
Implement integration tests to cover the new Wazuh DB commands that access the CVE table in the agents' databases #1069
Closed
DProvinciani
DProvinciani approved these changes Feb 26, 2021
View reviewed changes
Copy link
Contributor

@DProvinciani DProvinciani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@DProvinciani DProvinciani merged commit 95e2025 into dev-cves-by-agent Feb 26, 2021
@DProvinciani DProvinciani deleted the 1069-add-vuln-cve-insert-tests branch February 26, 2021 16:34
@DProvinciani DProvinciani mentioned this pull request Feb 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DProvinciani DProvinciani DProvinciani approved these changes

@MiguelazoDS MiguelazoDS Awaiting requested review from MiguelazoDS

@pereyra-m pereyra-m Awaiting requested review from pereyra-m

Assignees

@palaciosjeremias palaciosjeremias

Labels
None yet
Projects
None yet
Milestone
Sprint 125 - Core/Bugman
2 participants
@palaciosjeremias @DProvinciani