Remove the disk i/o % usage calculation from the performance tools #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdriiiPRodri
approved these changes
Sep 15, 2021
davidjiglesias
approved these changes
Sep 23, 2021
davidjiglesias
changed the title
|
Disk i/o % usage has been removed correctly - wazuh-analysisd |
jmv74211
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #1718.
After the investigation done in the related issue, the decision taken was to delete the
disk(%)measure from the process metrics.This pull request removes this metric.
I have tested this in our testing environment and the plots generated are the ones including: disk read and written KBs, disk read and write speed; and read and write ops. (Talking about plots showing disk information)
The plot including
disk(%)will no longer be created.Checks
pycodestyle --max-line-length=120 --show-source --show-pep8 file.py.provision_documentation.shgenerate the docs without errors.