Added test descriptions for documentation. #2176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiguelazoDS
force-pushed
the
dev-2154-tests_documentation
branch
from
2cfac29
to
2964342
Compare
DProvinciani
suggested changes
Nov 4, 2021
| it responds appropriately to them. In this case, the enrollment requests | ||
| are sent to an IP v4 network socket. | ||
| description: | ||
| Checks if when the `wazuh-authd` daemon receives different kinds of enrollment requests, |
There was a problem hiding this comment.
I know that this was written in this way before you created this PR, but taking advantage of the PR to improve the documentation, I would say different types instead of different kinds
There was a problem hiding this comment.
Good observation, I overlooked. Changed!
| for the new agent and deletes the old one. In this case, the enrollment requests | ||
| are sent to an IP v4 network socket. | ||
| description: | ||
| Check if when the 'wazuh-authd' daemon receives an enrollment request from an agent |
There was a problem hiding this comment.
Fixed. I found the same typo in other files too.
MiguelazoDS
force-pushed
the
dev-2154-tests_documentation
branch
from
945ed31
to
246694e
Compare
DProvinciani
merged commit 80c59c4
into
dev-9550-authd-replacement-configurations-improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes new documentation blocks for force_options tests and improves already documented tests
Tests
pycodestyle --max-line-length=120 --show-source --show-pep8 file.py.