Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change logtest custom rules ids #2177

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

Rebits
Copy link
Member

@Rebits Rebits commented Nov 4, 2021

Related issue
#2172

Description

This PR closes #2172 . Logtest custom rules ids have been replaced in order to avoid id overlap.

Tests

Package

Version Revision Link
4.3.0 40301 https://packages-dev.wazuh.com/warehouse/pullrequests/4.3/rpm/var/wazuh-manager-4.3.0-0.commit1eb36ec.x86_64.rpm

Testing

test_logtest

OS Local Jenkins Notes
PS1 🟢 🟢
PS2 🟢 🟢
PS3 🟢 🟢

  • 🟢: All pass

  • 🟡: Some warnings

  • 🔴: Some errors/fails

  • 🔵: In progress

  • Proven that tests pass when they have to pass.

  • Proven that tests fail when they have to fail.

  • Python codebase satisfies PEP-8 style style guide. pycodestyle --max-line-length=120 --show-source --show-pep8 file.py.
  • Python codebase is documented following the Google Style for Python docstrings.

@Rebits Rebits self-assigned this Nov 4, 2021
@juliamagan
Copy link
Member

juliamagan commented Nov 5, 2021

05/11/2021

Package

Version Revision Link
4.3.0 40301 https://packages-dev.wazuh.com/warehouse/pullrequests/4.3/rpm/var/wazuh-manager-4.3.0-0.commit1eb36ec.x86_64.rpm

Testing

tests/integration/test_logtest

OS Local Jenkins Notes
PS1 🟢 🟢
PS2 🟢 🟢
PS3 🟢 🟢

  • 🟢: All pass
  • 🟡: Some warnings
  • 🔴: Some errors/fails
  • 🔵: In progress

Copy link
Member

@juliamagan juliamagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snaow snaow merged commit 2342071 into master Nov 8, 2021
@snaow snaow deleted the 2172-logtest-custom-rules-id-overlap branch November 8, 2021 10:52
@snaow snaow mentioned this pull request Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logtest IT failured due rule id overlap
3 participants