Remove old check #2281
Merged
Remove old check #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdriiiPRodri
approved these changes
Nov 29, 2021
davidjiglesias
approved these changes
Nov 29, 2021
|
You are not only removing an old check, but you are also increasing the sleep timer. Remember to include all the details in the explanation. On top of that, please, improve the PR titles, "Remove old check" does not really mean anything. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This closes #2280. In this pull request, we removed a check the test was performing. This check looked in the
cluster.logfile, looking for a particular file. Due to a change in the code, these chunks are not going to be displayed anymore. As they are not shown anymore, the test was failing when trying to find them. The test is still functional, as now it only looks for this new information in theglobal.dbdatabase.