Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Cloud. IT Tests: Fixing and rework for 4.3.0-RC2 #2420

Merged
merged 7 commits into from
Jan 7, 2022

Conversation

snaow
Copy link
Contributor

@snaow snaow commented Dec 30, 2021

Related issue
#2369

Description

As the main issue stands, there were major problems considering that several logging sentences were changed in the source code but the tests were not adapted accordingly.

The PR resolves the following issues:

  • Improve tests and module documentation tags and update Docs Schema
  • Adapt the regular expressions to capture the correct sentence from software logs
  • Refactor various tests to restart single daemon instead of full service (increase x15 speed)
  • Fix test_schedule: acuum_result=2 was not needed
  • Various tests were failing cause the log file wasn't being truncated properly
  • Remove mkdocs.yml (unrelated to this PR) since is no anymore in use
  • New session fixture to set internal options values
  • Fix test_remote_configuration
  • Removed TimeTravels from test_day_wday since they are no consistent at all. We can not rely on TimeTravel to make the tests work properly.

Safety checks

  • Attached successful runs [Attaching Pytest reports instead QACTL report until QACTL allows to load custom files (configuration.yaml)]
  • Attached Jenkins pipeline successful build

Status

Round # Test Jenkins Local Note
Round 1 integration/test_gcloud 🟢 🟢 -
Round 2 integration/test_gcloud 🟢 🟢 -
Round 3 integration/test_gcloud 🟢 🟢 -

(*) Keep in mind that there is no way to include configuration.yaml dynamically before running QACTL. Which means that the first run fails cause the file is not there, you need to upload it manually to the vagrant box and then re-run the test.

@snaow snaow self-assigned this Dec 30, 2021
@snaow snaow marked this pull request as ready for review January 3, 2022 18:30
@snaow snaow requested a review from danisan90 January 3, 2022 18:30
@danisan90
Copy link
Contributor

Tests

Run Results Date By
R1 🟢 04/01/2022 @danisan90
R2 🟢 04/01/2022 @danisan90
R3 🟢 04/01/2022 @danisan90

danisan90
danisan90 previously approved these changes Jan 4, 2022
Copy link
Contributor

@danisan90 danisan90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snaow snaow changed the title Google Cloud. IT Tests: Fix incorrect regular expressions and doc tags. Google Cloud. IT Tests: Fixing and rework for 4.3.0-RC2 Jan 5, 2022
@snaow snaow merged commit d5d9be7 into master Jan 7, 2022
@snaow snaow deleted the 2369-gcloud-4.3.0 branch January 7, 2022 07:06
@snaow snaow linked an issue Jan 7, 2022 that may be closed by this pull request
@snaow snaow mentioned this pull request Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Cloud integration tests: Incorrect regular expressions and others
2 participants