Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IT Integratord: Add new test integratord alerts messages #3125

Merged
merged 45 commits into from
Aug 9, 2022
Merged

IT Integratord: Add new test integratord alerts messages #3125

merged 45 commits into from
Aug 9, 2022

Conversation

Deblintrake09
Copy link
Contributor

@Deblintrake09 Deblintrake09 commented Jul 25, 2022 •
edited
Loading

Related issue
Closes #2944

Description

This PR aims to add coverage to the Integratord module, by generating alerts and checking the responses on the ossec.log.

Added

The following test modules were added as part of the the new test_integratord test suite

  • test_integratord_change_inode_alert.py
  • test_integratord_read_json_alerts.py
  • test_integratord_read_json_file_deleted.py

Testing performed

Tester Test path Jenkins Local OS Commit Notes
@Deblintrake09 (Developer) 🟢 🟢 🟢 🟢 🟢 🟢 Centos 9ee89bd package
@user (Reviewer) ⚫⚫⚫ 🚫 🚫 🚫 Nothing to highlight

@Deblintrake09
Add: test_integratord_read_json_alerts test module
1a67a16
@Deblintrake09
Add: load_configurations and get_test_cases_data
e79c873
@Deblintrake09
Add: restart_wazuh_function no get_configuration
866995c
@Deblintrake09
Add: integratord folder for extranct variables and
6b790e7 
functions
@Deblintrake09
rm: removed error messages metadata
8b68fd1
@Deblintrake09
Add: create integratord conftest
f70e4a4
@Deblintrake09
Add: add restart_wazuh_function fixture
254b450 
(it does not use get_configuration)
@Deblintrake09
Refac & Docu: extract variables and fix docum
4c4ef4c
@Deblintrake09
Add: set_wazuh_configuration fixture (does not use get_configuration)
932f05c
@Deblintrake09
Fix: fixed conf file - problem with authd daemon
aa69011
@Deblintrake09
Add: added test case for removed json file
fe36859
@Deblintrake09
Add: truncate_monitored_files fixture
380f825
@Deblintrake09
Fix: refactor read_json_alerts and extract cases
a5a9282
@Deblintrake09
Add: new read_json_file_deleted test module
be68835
@Deblintrake09
Docu: updated documentation
3474289
@Deblintrake09
Add: new callbacks and error messages
0f9f1f7
@Deblintrake09
Fix: extract variables and fix format
8673408
@Deblintrake09
refactor: delete unecesary metadata
a636736
@Deblintrake09
Add: new test change_inode_alert
3d20241
@Deblintrake09
style: fix pycodestyle
260aa4c
@Deblintrake09
style: fix style
078a532
@Deblintrake09
refactor: change variables to raw strings
1af8af6
@Deblintrake09 Deblintrake09 changed the title 2944.test.integratord.fix IT Integratord: Add new test integratord alerts messages Jul 25, 2022
@Deblintrake09 Deblintrake09 changed the base branch from master to 4.3 July 26, 2022 12:01
@Deblintrake09 Deblintrake09 marked this pull request as ready for review July 28, 2022 13:55
jmv74211
jmv74211 suggested changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@jmv74211 jmv74211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only checked the first test case. Please, apply the mentioned changes, and I will review the next ones after that.

tests/integration/test_integratord/conftest.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
tests/integration/test_integratord/data/test_cases/cases_integratord_read_json_alerts.yaml Outdated Show resolved Hide resolved
tests/integration/test_integratord/data/test_cases/cases_integratord_read_json_alerts.yaml Outdated Show resolved Hide resolved
tests/integration/test_integratord/test_integratord_read_json_alerts.py Outdated Show resolved Hide resolved
@Deblintrake09
Style: fixe pycodestyle
cb3e325
@Deblintrake09
Docu: updated changelog.md
1147271
@Deblintrake09
Add: extract local_actions from QACTL to tools
02bed20
@Deblintrake09
Add: integratord event_monitor
352bfb5
@Deblintrake09
Fix: refactor integratord_change_inode_alert.py
5886197
@Deblintrake09
Docu: change documentation comments
f16839c
@Deblintrake09
Fix: separate read_json_alerts in two
07e6330 
tests (valid/invalid)
@Deblintrake09
Fix: refactor tests and extract os commands
3248dac
@Deblintrake09
Fix: remofactor wait_for_start_module
65749ed
@Deblintrake09
Fix: remove api_key value from yaml
962e428
@Deblintrake09
Add: new integration_api_key parameter
e845a7f
@Deblintrake09
Fix: add API_KEY parameter
1003065
@Deblintrake09
style: Fix style to comply with PEP8
b0859a2
@Deblintrake09
style: fix style to comply with PEP 8 #3125
e32b7e1
@Deblintrake09
style: Fix yaml style #3125
c0720fb
@Deblintrake09
style: fix yaml indentations #3125
a389c2f
@Deblintrake09
style: Fix yaml indentation #3125
1cc89b1
@Deblintrake09
style: Fix yaml indentation and style #3125
0ed18c3
@Deblintrake09
style: fix yaml style #3125
9ee89bd
@jmv74211 jmv74211 merged commit 998976a into 4.3 Aug 9, 2022
@jmv74211 jmv74211 deleted the 2944.test.integratord.fix branch August 9, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmv74211 jmv74211 jmv74211 approved these changes

Assignees

@Deblintrake09 Deblintrake09

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create tests for different types of inputs for the integrator module
2 participants
@Deblintrake09 @jmv74211