Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor test_remove_audit to retry package installation if busy #3562

Merged
merged 4 commits into from
Nov 4, 2022
Merged

Refactor test_remove_audit to retry package installation if busy #3562

merged 4 commits into from
Nov 4, 2022

Conversation

fedepacher
Copy link
Contributor

Related issue
#3402

Description

This PR aims to solve the problem in the FIM test test_remove_audit.py when it tries to install a package and the subprocess apt-get is busy.

Testing performed

Tester Test path Jenkins Local OS Commit Notes
@user (Developer) 🟢 🟢 🟢 🟢 Nothing to highlight
@user (Reviewer) ⚫⚫⚫ 🚫 🚫 🚫 Nothing to highlight

@fedepacher fedepacher self-assigned this Nov 3, 2022
Rebits
Rebits requested changes Nov 3, 2022
View reviewed changes
Copy link
Member

@Rebits Rebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ but some changes are required

CHANGELOG.md Outdated Show resolved Hide resolved
tests/integration/test_fim/test_files/test_audit/test_remove_audit.py Outdated Show resolved Hide resolved
Rebits
Rebits approved these changes Nov 3, 2022
View reviewed changes
Copy link
Member

@Rebits Rebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rebits Rebits linked an issue Nov 3, 2022 that may be closed by this pull request
Unstable FIM tests for Ubuntu agent - 4.4 #3402
Closed
jmv74211
jmv74211 suggested changes Nov 4, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
tests/integration/test_fim/test_files/test_audit/test_remove_audit.py Outdated Show resolved Hide resolved
@jmv74211 jmv74211 merged commit 0643dba into 4.4 Nov 4, 2022
@jmv74211 jmv74211 deleted the 3402-test-remove-audit branch November 4, 2022 12:49
Deblintrake09 added a commit that referenced this pull request Jan 3, 2023
@Deblintrake09
fix(#3562): add missing imports
ea4bf0c
Deblintrake09 added a commit that referenced this pull request Jan 3, 2023
@Deblintrake09
feat(#3562): add generic fim event checker
8144336
Deblintrake09 added a commit that referenced this pull request Jan 3, 2023
@Deblintrake09
fix(#3562): update event checker for espaced paths
a6da1f1
Deblintrake09 added a commit that referenced this pull request Jan 3, 2023
@Deblintrake09
feat(#3562): update test and add new test cases
358463f
Deblintrake09 added a commit that referenced this pull request Jan 3, 2023
@Deblintrake09
fix(#3562): add missing imports
d9b8690
Deblintrake09 added a commit that referenced this pull request Jan 3, 2023
@Deblintrake09
feat(#3562): add generic fim event checker
9bbdfab
Deblintrake09 added a commit that referenced this pull request Jan 3, 2023
@Deblintrake09
fix(#3562): update event checker for espaced paths
9f8e06b
Deblintrake09 added a commit that referenced this pull request Jan 3, 2023
@Deblintrake09
feat(#3562): update test and add new test cases
1c1df83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rebits Rebits Rebits approved these changes

@jmv74211 jmv74211 jmv74211 approved these changes

Assignees

@fedepacher fedepacher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unstable FIM tests for Ubuntu agent - 4.4
3 participants
@fedepacher @Rebits @jmv74211