Add logcollector ignore and restrict IT tests #3582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deblintrake09
changed the title
15 tasks
Deblintrake09
added
team/qa
feature/logcollector
feature/fim
and removed
feature/fim
labels
damarisg
requested changes
Nov 24, 2022
There was a problem hiding this comment.
I requested some changes. Also, I would like to know what happens when we add only two ignore tags or two restrict tags in the same configuration.
Ignore tag works as OR, and restrict tag works as AND, but I didn't see any cases of this added. Was it for some reason?
tests/integration/test_logcollector/test_log_filter_options/test_ignore_regex.py
Outdated
Show resolved
Hide resolved
tests/integration/test_logcollector/test_log_filter_options/test_ignore_regex.py
Outdated
Show resolved
Hide resolved
tests/integration/test_logcollector/test_log_filter_options/test_ignore_regex.py
Outdated
Show resolved
Hide resolved
tests/integration/test_logcollector/test_log_filter_options/test_ignore_regex.py
Outdated
Show resolved
Hide resolved
tests/integration/test_logcollector/test_log_filter_options/test_restrict_regex.py
Outdated
Show resolved
Hide resolved
...logcollector/test_log_filter_options/data/test_cases/cases_restrict_ignore_regex_values.yaml
Outdated
Show resolved
Hide resolved
...logcollector/test_log_filter_options/data/test_cases/cases_restrict_ignore_regex_values.yaml
Outdated
Show resolved
Hide resolved
...logcollector/test_log_filter_options/data/test_cases/cases_restrict_ignore_regex_values.yaml
Outdated
Show resolved
Hide resolved
...logcollector/test_log_filter_options/data/test_cases/cases_restrict_ignore_regex_values.yaml
Outdated
Show resolved
Hide resolved
...logcollector/test_log_filter_options/data/test_cases/cases_restrict_ignore_regex_values.yaml
Outdated
Show resolved
Hide resolved
Deblintrake09
pushed a commit
that referenced
this pull request
Nov 28, 2022
Changes: - Added ansible structure to QA's repo - Added two new roles: `apache` and `qa_framework` roles - `customize` flag has been added to `qa_framework` role: by setting this as true, we can customize any var within all hosts `apache` role works on all systems but in Solaris and macOS it freezes during the Apache installation.
damarisg
requested changes
Nov 30, 2022
tests/integration/test_logcollector/test_log_filter_options/test_restrict_ignore_regex.py
Outdated
Show resolved
Hide resolved
tests/integration/test_logcollector/test_log_filter_options/test_ignore_regex.py
Outdated
Show resolved
Hide resolved
tests/integration/test_logcollector/test_log_filter_options/test_restrict_regex.py
Outdated
Show resolved
Hide resolved
tests/integration/test_logcollector/test_log_filter_options/test_restrict_regex.py
Outdated
Show resolved
Hide resolved
damarisg
previously approved these changes
Dec 7, 2022
Co-authored-by: Dámaris <[email protected]>
Deblintrake09
force-pushed
the
3480-logcollector-filter-options
branch
from
a56fc8f
to
b195b8b
Compare
jmv74211
suggested changes
Dec 15, 2022
deps/wazuh_testing/wazuh_testing/modules/logcollector/event_monitor.py
Outdated
Show resolved
Hide resolved
deps/wazuh_testing/wazuh_testing/modules/logcollector/event_monitor.py
Outdated
Show resolved
Hide resolved
tests/integration/test_logcollector/test_log_filter_options/test_ignore_regex.py
Outdated
Show resolved
Hide resolved
tests/integration/test_logcollector/test_log_filter_options/test_ignore_regex.py
Outdated
Show resolved
Hide resolved
jmv74211
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add new tests to the logcollector integration test suite related to the new
restrictandignoreoptions. When adding this options to alocationtag, incoming logs will be ignored and not set for analysis if they do not match a configured restrict tag or if they match a configured ignore tag. The new options allow for 3 different regex engines to match the logs (PCRE2, osregex and osmatch).This PR adds a total of 48 new test cases. All tests have been added to
test_logcollector/test_optionssuite.Added
test_ignore_regexmodule adds 12 test cases for ignore tag, with default and type value configured.test_restrict_regexmodule adds 12 test cases for restrict tag, with default and type value configured.test_restrict_ignore_regexmodule adds 24 test cases with one ignore and one restrict tag, with different combination of regex types and matching either one of the tags, none, or both.Testing performed