Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Yara and Virustotal E2E tests #3660

Merged
merged 9 commits into from
Dec 16, 2022
Merged

Fix Yara and Virustotal E2E tests #3660

merged 9 commits into from
Dec 16, 2022

Conversation

Rebits
Copy link
Member

@Rebits Rebits commented Dec 9, 2022

Related issue
#3657

Description

This PR fix Virustotal and Yara E2E tests

Updated

  • Yara E2E test configuration playbook
  • Virustotal E2E test timeout

Testing performed

Tester Test path Jenkins Local OS Commit Notes
@user (Developer) 🟢 Not apply Nothing to highlight
@user (Reviewer) ⚫⚫⚫ 🚫 🚫 🚫 Nothing to highlight

@Rebits Rebits self-assigned this Dec 9, 2022
@Rebits Rebits linked an issue Dec 9, 2022 that may be closed by this pull request
E2E test_yara_integration and test_virustotal_integration failure #3657
Closed
@Rebits
Copy link
Member Author

Rebits commented Dec 12, 2022

Update 12/12/2022

E2E Test iteration VirusTotal Yara
Build 🟢 🟢
Build 🟢 🟢
Build 🔴 🟢

@Rebits
Copy link
Member Author

Rebits commented Dec 12, 2022

Update 12/12/2022

After increasing the timeout of Virustotal to 90 seconds E2E tests seems to works as expected.

E2E Test iteration VirusTotal Yara
Build 🟢 🟢
Build 🟢 🟢
Build 🟢 🟢

@jmv74211 jmv74211 self-requested a review December 16, 2022 09:22
@jmv74211 jmv74211 merged commit 237ee22 into 4.4 Dec 16, 2022
@jmv74211 jmv74211 deleted the 3657-fix-e2e-test-yara-virustotal branch December 16, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmv74211 jmv74211 jmv74211 approved these changes

Assignees

@Rebits Rebits

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

E2E test_yara_integration and test_virustotal_integration failure
2 participants
@Rebits @jmv74211