Update the Authd response when a multigroup is too long #3746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vikman90
force-pushed
the
15861-fix-authd-overflow
branch
from
414118c
to
fa6a071
Compare
vikman90
force-pushed
the
15861-fix-authd-overflow
branch
from
bbc3218
to
90c8f31
Compare
Rebits
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The issue above aims to prevent a read buffer overflow in Authd. One of the changes is to check that the multigroup part of the message is valid (it's enclosed between single-quotes), otherwise it reports the message:
This check is previous to the multigroup syntax validation, and that's why the response has changed.
Updated
Testing performed