Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add localfile wildcard support for windows IT #3906

Closed
wants to merge 22 commits into from
Closed

Add localfile wildcard support for windows IT #3906

wants to merge 22 commits into from

Conversation

Deblintrake09
Copy link
Contributor

@Deblintrake09 Deblintrake09 commented Feb 7, 2023 •
edited
Loading

Related issue
#3786

Description

This PR adds test support for wildcards usage in the localfile location tag for Windows agents.

Added

  • Added 6 test cases in /test_logcollector/test_location_wildcards suite. Testing different wildcards combinations and a case where wildcards do not match a valid file

Testing performed

Tester Test path Jenkins Local OS Commit Notes
@Deblintrake09 (Developer) test_logcollector 🟢🟢🟢 Manager 35f4ac6 Nothing to highlight
@Deblintrake09 (Developer) test_logcollector 🟢🟢🟢 Linux agent 35f4ac6 Nothing to highlight
@Deblintrake09 (Developer) test_logcollector 🟢🟢🟢 Windows agent 35f4ac6 Nothing to highlight
@damarisg (Reviewer) test_logcollector 🟢 🚫 🚫 🚫 Manager ae13d71 Nothing to highlight
@damarisg (Reviewer) test_logcollector 🟢 🚫 🚫 🚫 Linux agent ae13d71 Nothing to highlight
@damarisg (Reviewer) test_logcollector 🟢 🚫 🚫 🚫 Windows agent ae13d71 Nothing to highlight
@damarisg (Reviewer) test_logcollector 🟢 🚫 🚫 🚫 Solaris and macOS agent ae13d71 Nothing to highlight
@Deblintrake09 (Developer) test_logcollector 🟢 Manager 5de9cca Additional results after moving test to new folder
@Deblintrake09 (Developer) test_logcollector 🟢 Linux agent 5de9cca Additional results after moving test to new folder
@Deblintrake09 (Developer) test_logcollector 🟢 Windows agent 5de9cca Additional results after moving test to new folder

@Deblintrake09 Deblintrake09 self-assigned this Feb 7, 2023
@Deblintrake09 Deblintrake09 changed the base branch from master to 4.5 February 7, 2023 19:37
@Deblintrake09 Deblintrake09 linked an issue Feb 7, 2023 that may be closed by this pull request
Add log monitoring using wildcards for folders on Windows IT Support #3786
Closed
6 tasks
@Deblintrake09 Deblintrake09 marked this pull request as ready for review February 8, 2023 19:20
damarisg
damarisg requested changes Mar 31, 2023
View reviewed changes
Copy link
Member

@damarisg damarisg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need that you check the executions, because I found failures.

@Deblintrake09 Deblintrake09 requested review from damarisg and juliamagan and removed request for jmv74211 April 25, 2023 12:27
juliamagan
juliamagan requested changes Apr 28, 2023
View reviewed changes
Copy link
Member

@juliamagan juliamagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!

Since these tests only apply to Windows, I would rename them by adding win somewhere for clarification, and add them to the test_location module, instead of creating a new one, since they test the same thing.

deps/wazuh_testing/wazuh_testing/modules/logcollector/event_monitor.py Outdated Show resolved Hide resolved
tests/integration/test_logcollector/test_configuration/test_basic_configuration_log_format.py Outdated Show resolved Hide resolved
...tion/test_logcollector/test_location_wildcards/data/test_cases/cases_location_wildcards.yaml Outdated Show resolved Hide resolved
juliamagan
juliamagan requested changes May 4, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
juliamagan
juliamagan approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@juliamagan juliamagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Deblintrake09 Deblintrake09 removed a link to an issue Jul 3, 2023
Add log monitoring using wildcards for folders on Windows IT Support #3786
Closed
6 tasks
@Deblintrake09
Copy link
Contributor Author

Branch was recreated in #4263 since this branch has unverified commits.

@Deblintrake09 Deblintrake09 deleted the 3786-logcollector-wildcards branch July 4, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damarisg damarisg damarisg approved these changes

@juliamagan juliamagan juliamagan approved these changes

Assignees

@Deblintrake09 Deblintrake09

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Deblintrake09 @damarisg @juliamagan @jmv74211