Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unstable system tests #4080

Merged
merged 10 commits into from
Apr 12, 2023
Merged

Fix unstable system tests #4080

merged 10 commits into from
Apr 12, 2023

Conversation

Rebits
Copy link
Member

@Rebits Rebits commented Apr 11, 2023 •
edited
Loading

Related issue
#4079

Description

Added

  • Markers for missing system tests

Updated

  • README to include all system tests
  • Fix tests active response test
  • Fix enrollment cluster log path typo
  • Fix test assign groups guess test

Testing performed

Tester Test path Jenkins Local OS Commit Notes
@Rebits (Developer) 🚫 🚫 🚫 ⚫⚫⚫ Nothing to highlight
@juliamagan (Reviewer) 🚫 🚫 🚫 🚫 🚫 🚫 Nothing to highlight

@Rebits Rebits self-assigned this Apr 11, 2023
@Rebits Rebits linked an issue Apr 11, 2023 that may be closed by this pull request
Unstable system tests for 4.4.0 #4079
Closed
@Rebits
Copy link
Member Author

Rebits commented Apr 11, 2023

All system tests are now included in the README. In addition, markers contain all the system tests

Number of tests by environment
Enrollment cluster 
rebits@pop-os:~/Wazuh/wazuh-qa/4.4$ ../../system_tests/bin/python3.10  -m pytest --collect-only tests/system/ -m enrollment_cluster_env
...
============================================================================================== 30/129 tests collected (99 deselected) in 0.47s ===============================================================================================
Basic cluster 
rebits@pop-os:~/Wazuh/wazuh-qa/4.4$ ../../system_tests/bin/python3.10  -m pytest --collect-only tests/system/ -m basic_cluster_env
...
============================================================================================== 11/129 tests collected (118 deselected) in 0.50s ==============================================================================================
Basic environment 
rebits@pop-os:~/Wazuh/wazuh-qa/4.4$ ../../system_tests/bin/python3.10  -m pytest --collect-only tests/system/ -m basic_environment_env

...
============================================================================================== 40/129 tests collected (89 deselected) in 0.51s ===============================================================================================
Agentless cluster 

rebits@pop-os:~/Wazuh/wazuh-qa/4.4$ ../../system_tests/bin/python3.10  -m pytest --collect-only tests/system/ -m agentless_cluster_env
***
============================================================================================== 24/129 tests collected (105 deselected) in 0.49s ==============================================================================================
Manager Agent 
rebits@pop-os:~/Wazuh/wazuh-qa/4.4$ ../../system_tests/bin/python3.10  -m pytest --collect-only tests/system/ -m manager_agent_env
...
============================================================================================== 3/129 tests collected (126 deselected) in 0.52s ===============================================================================================
One manager agent 
rebits@pop-os:~/Wazuh/wazuh-qa/4.4$ ../../system_tests/bin/python3.10  -m pytest --collect-only tests/system/ -m one_manager_agent_env
...
============================================================================================== 15/129 tests collected (114 deselected) in 0.52s ==============================================================================================

juliamagan
juliamagan requested changes Apr 11, 2023
View reviewed changes
CHANGELOG.md Outdated
@@ -9,6 +9,7 @@ Release report: https:/wazuh/wazuh/issues/15504

### Added

- Fix unstable system tests ([#4080](https:/wazuh/wazuh-qa/pull/4080)) \- (Tests)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this to Fixed section

Copy link
Member Author

@Rebits Rebits Apr 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 4c5f065

@Rebits Rebits force-pushed the 4079-fix-system-unstable-tests branch from db8a95a to 4c5f065 Compare April 12, 2023 15:47
@Rebits Rebits force-pushed the 4079-fix-system-unstable-tests branch from 43209d4 to 521b655 Compare April 12, 2023 15:53
@juliamagan juliamagan merged commit 21e912c into 4.4 Apr 12, 2023
@juliamagan juliamagan deleted the 4079-fix-system-unstable-tests branch April 12, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliamagan juliamagan juliamagan approved these changes

Assignees

@Rebits Rebits

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unstable system tests for 4.4.0
2 participants
@Rebits @juliamagan