-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance FIM IT test_ambiguous_confs suite #4121
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deblintrake09
force-pushed
the
3591-enhance-ambiguous-confsv2
branch
from
April 24, 2023 20:59
ff5e1db
to
446aeba
Compare
damarisg
requested changes
Apr 26, 2023
tests/integration/test_fim/test_files/test_restrict/test_restrict_valid.py
Outdated
Show resolved
Hide resolved
damarisg
approved these changes
Apr 27, 2023
juliamagan
previously requested changes
Apr 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GJ!
There are some requested changes
tests/integration/test_fim/test_files/test_ambiguous_confs/test_ignore_works_over_restrict.py
Outdated
Show resolved
Hide resolved
tests/integration/test_fim/test_files/test_ambiguous_confs/test_ignore_works_over_restrict.py
Outdated
Show resolved
Hide resolved
.../integration/test_fim/test_files/test_ambiguous_confs/test_whodata_prevails_over_realtime.py
Show resolved
Hide resolved
.../integration/test_fim/test_files/test_ambiguous_confs/test_whodata_prevails_over_realtime.py
Outdated
Show resolved
Hide resolved
.../integration/test_fim/test_files/test_ambiguous_confs/test_whodata_prevails_over_realtime.py
Outdated
Show resolved
Hide resolved
damarisg
requested review from
juliamagan and
damarisg
and removed request for
juliamagan
May 23, 2023 11:13
damarisg
approved these changes
May 23, 2023
damarisg
dismissed
juliamagan’s stale review
May 23, 2023 11:21
Verified that ITs are stable on Solaris and macOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Issue aims to update the
test_fim/test_files/test_ambiguous_confs
IT suite to the new framework standard.During local executions for Windows agent, it was found some test failed because they were related to an unknown bug or had flaky behavior. This tests have been
skipped
orxfailed
and have been added to Issue #4077 so the bug can be tracked and can be fixed later.Updated
test_fim/test_files/test_ambiguous_confs/test_ambiguous_whodata_thread.py
test_fim/test_files/test_ambiguous_confs/test_whodata_prevails_over_realtime.py
test_fim/test_files/test_ambiguous_confs/test_ignore_works_over_restrict.py
Testing performed