Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance FIM IT test_ambiguous_confs suite #4121

Merged
merged 19 commits into from
May 23, 2023
Merged

Conversation

Deblintrake09
Copy link
Contributor

@Deblintrake09 Deblintrake09 commented Apr 24, 2023

Related issue
#3591

Description

This Issue aims to update the test_fim/test_files/test_ambiguous_confs IT suite to the new framework standard.

During local executions for Windows agent, it was found some test failed because they were related to an unknown bug or had flaky behavior. This tests have been skipped or xfailed and have been added to Issue #4077 so the bug can be tracked and can be fixed later.

Updated

  • Updated test_fim/test_files/test_ambiguous_confs/test_ambiguous_whodata_thread.py
  • Updated test_fim/test_files/test_ambiguous_confs/test_whodata_prevails_over_realtime.py
  • Updated test_fim/test_files/test_ambiguous_confs/test_ignore_works_over_restrict.py

Testing performed

Tester Test path Jenkins Local OS Commit Notes
@Deblintrake09 (Developer) test_fim 🟢🟢🟢 🟢🟢🟢 Manager 4428c8a Nothing to highlight
@Deblintrake09 (Developer) test_fim 🟢🟢🟢 🟢🟢🟢 Linux Agent 4428c8a Nothing to highlight
@Deblintrake09 (Developer) test_fim 🟢🟢🟢 🟢🟢🟢 Windows Agent 4428c8a Nothing to highlight
@Deblintrake09 (Developer) test_fim 🟢🟢🟢 ⚫⚫⚫ Solaris and macOs Agent 4428c8a Nothing to highlight
@damarisg (Reviewer) test_fim 🟢 🚫 🚫 🚫 Linux Agent 78f1c56 Nothing to highlight
@damarisg (Reviewer) test_fim 🟢 🚫 🚫 🚫 Manager 78f1c56 Nothing to highlight
@damarisg (Reviewer) test_fim 🟢 🚫 🚫 🚫 Windows Agent 78f1c56 Nothing to highlight

@Deblintrake09 Deblintrake09 linked an issue Apr 24, 2023 that may be closed by this pull request
Copy link
Member

@juliamagan juliamagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!

There are some requested changes

@damarisg damarisg requested review from juliamagan and damarisg and removed request for juliamagan May 23, 2023 11:13
@damarisg damarisg dismissed juliamagan’s stale review May 23, 2023 11:21

Verified that ITs are stable on Solaris and macOS.

@damarisg damarisg merged commit 75b5e97 into 4.5 May 23, 2023
@damarisg damarisg deleted the 3591-enhance-ambiguous-confsv2 branch May 23, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance FIM test_ambiguous_confs test suite
3 participants