Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix analysisd windows registry test failure #4149

Merged
merged 2 commits into from
May 11, 2023

Conversation

QU3B1M
Copy link
Member

@QU3B1M QU3B1M commented May 5, 2023

Related issue
#4112

Description

The analysisd IT tests /test_all_syscheckd_configurations/test_validate_win32_analysisd_registry_alerts.py were failing because a missing index key on the yaml cases.

Updated

  • tests/integration/test_analysisd/test_all_syscheckd_configurations/test_validate_win32_analysisd_registry_alerts.py

Testing performed

Tester Test path Jenkins Local OS Commit Notes
@QU3B1M (Developer) integration/test_analysisd/test_all_syscheckd_configurations/test_validate_win32_analysisd_registry_alerts.py ⚫⚫⚫ 🟢 🟢 🟢 Ubuntu 22.04 3ed817e Nothing to highlight
@damarisg (Reviewer) test_analysisd/ 🟢 🚫 🚫 🚫 centOS - Manager 3ed817e Tier 0, 1
@damarisg (Reviewer) test_analysisd/ 🟢 🚫 🚫 🚫 centOS - Manager 3ed817e Tier 2

@QU3B1M QU3B1M self-assigned this May 5, 2023
@QU3B1M QU3B1M linked an issue May 5, 2023 that may be closed by this pull request
@QU3B1M QU3B1M requested a review from damarisg May 5, 2023 00:16
@QU3B1M QU3B1M marked this pull request as ready for review May 5, 2023 00:16
@QU3B1M
Copy link
Member Author

QU3B1M commented May 5, 2023

The linting check is failing because the yaml is not correctly formatted, it has too many lines to fix that makes it complicated

Copy link
Member

@juliamagan juliamagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juliamagan juliamagan merged commit a474f43 into 4.5 May 11, 2023
@juliamagan juliamagan deleted the 4112-fix-windows-registry-event-cases branch May 11, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows Registry Analysisd IT failure
3 participants