Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit urllib3 major required version #4162

Merged
merged 1 commit into from
May 16, 2023

Conversation

jnasselle
Copy link
Member

@jnasselle jnasselle commented May 11, 2023

Related issue
wazuh/wazuh-jenkins#5074
#4163

Description

Repository requirements.txt request urllib3>=1.26.5, but since April 26 2023 urllib3 2.0.0 was released having breaking changes like urllib3/urllib3#2168 that not only have impact on our Jenkins CICD pipelines/envs but could break our IT any minute.

Updated

  • urllib3 major version to be lower than 2

Testing performed

FIM IT on macOS and Solaris went well https://ci.wazuh.info/job/Test_integration/38516/ 🟢

Tester Test path Jenkins Local OS Commit Notes
@jnasselle (Developer) ⚫⚫⚫ ⚫⚫⚫ Nothing to highlight
@BelenValdivia (Reviewer) test_active_response/ 🟢 🚫 🚫 🚫 CentOS - Manager tests 56763d3 Nothing to highlight
@BelenValdivia (Reviewer) test_active_response/ 🟢 🚫 🚫 🚫 CentOS - Agent tests 56763d3 Nothing to highlight
@BelenValdivia (Reviewer) test_active_response/ 🟢 🚫 🚫 🚫 Windows- Agent tests 56763d3 Nothing to highlight
@BelenValdivia (Reviewer) test_agentd/ 🟢 🚫 🚫 🚫 CentOS - Agent tests 56763d3 Nothing to highlight
@BelenValdivia (Reviewer) test_agentd/ 🟢 🚫 🚫 🚫 Windows - Agent tests 56763d3 Nothing to highlight
@BelenValdivia (Reviewer) test_analysisd/ 🟢 🚫 🚫 🚫 CentOS- Manager tests 56763d3 Nothing to highlight
@BelenValdivia (Reviewer) test_api/ 🟢 🚫 🚫 🚫 CentOS- Manager tests 56763d3 Nothing to highlight
@BelenValdivia (Reviewer) test_authd/ 🟢 🚫 🚫 🚫 CentOS- Manager tests 56763d3 Nothing to highlight
@BelenValdivia (Reviewer) test_gcloud/ 🟢 🚫 🚫 🚫 CentOS- Manager tests 56763d3 Nothing to highlight
@BelenValdivia (Reviewer) test_github/ 🟢 🚫 🚫 🚫 CentOS- Manager tests 56763d3 Nothing to highlight
@BelenValdivia (Reviewer) test_github/ 🟢 🚫 🚫 🚫 CentOS- Agent tests 56763d3 Nothing to highlight
@BelenValdivia (Reviewer) test_logtest/ 🟢 🚫 🚫 🚫 CentOS- Manager tests 56763d3 Nothing to highlight
@BelenValdivia (Reviewer) test_office365/ 🟢 🚫 🚫 🚫 CentOS- Manager tests 56763d3 Nothing to highlight
@BelenValdivia (Reviewer) test_office365/ 🟢 🚫 🚫 🚫 CentOS- Agent tests 56763d3 Nothing to highlight
@BelenValdivia (Reviewer) test_remoted/ 🟢 🚫 🚫 🚫 CentOS- Manager tests 56763d3 Nothing to highlight
@BelenValdivia (Reviewer) test_rids/ 🟢 🚫 🚫 🚫 CentOS- Manager tests 56763d3 Nothing to highlight
@BelenValdivia (Reviewer) test_rootcheck/ 🟢 🚫 🚫 🚫 CentOS- Manager tests 56763d3 Nothing to highlight
@BelenValdivia (Reviewer) test_wazuh_db/ 🟢 🚫 🚫 🚫 CentOS- Manager tests 56763d3 Nothing to highlight
@BelenValdivia (Reviewer) test_enrollment/ 🟢 🚫 🚫 🚫 CentOS- Agent tests 56763d3 Nothing to highlight
@BelenValdivia (Reviewer) test_enrollment/ 🟢 🚫 🚫 🚫 Windows- Agent tests 56763d3 Nothing to highlight
@BelenValdivia (Reviewer) test_fim/ 🟢 🚫 🚫 🚫 CentOS- Manager tests 56763d3 Nothing to highlight
@BelenValdivia (Reviewer) test_fim/ 🟢 🚫 🚫 🚫 CentOS- Agent tests 56763d3 Nothing to highlight
@BelenValdivia (Reviewer) test_fim/ 🟢 🚫 🚫 🚫 Windows- Agent tests 56763d3 Nothing to highlight
@BelenValdivia (Reviewer) test_fim/ 🟢 🚫 🚫 🚫 MacOS- Agent tests 56763d3 Nothing to highlight
@BelenValdivia (Reviewer) test_fim/ 🟢 🚫 🚫 🚫 Solaris- Agent tests 56763d3 Nothing to highlight
@BelenValdivia (Reviewer) test_vulnerability_detector/ 🔴 🚫 🚫 🚫 CentOS- Manager tests 56763d3 RHEL5, ALAS and ALAS-2 feeds tests have failed due to feeds has not been recently updated
@BelenValdivia (Reviewer) test_logcollector/ 🟢 🚫 🚫 🚫 CentOS- Manager tests 56763d3 Nothing to highlight
@BelenValdivia (Reviewer) test_logcollector/ 🟢 🚫 🚫 🚫 CentOS- Agent tests 56763d3 Nothing to highlight
@BelenValdivia (Reviewer) test_logcollector/ 🟢 🚫 🚫 🚫 Windows- Agent tests 56763d3 Nothing to highlight
@BelenValdivia (Reviewer) test_logcollector/ 🟢 🚫 🚫 🚫 Solaris- Agent tests 56763d3 Nothing to highlight
@BelenValdivia (Reviewer) test_logcollector/ 🟢 🚫 🚫 🚫 MacOS- Agent tests 56763d3 Nothing to highlight

@jnasselle jnasselle self-assigned this May 11, 2023
@jnasselle jnasselle linked an issue May 12, 2023 that may be closed by this pull request
@jnasselle jnasselle force-pushed the 5074-limit-urllib3-required-version branch from c41a96c to 56763d3 Compare May 12, 2023 14:34
@jnasselle jnasselle marked this pull request as ready for review May 12, 2023 14:34
Copy link
Contributor

@mauromalara mauromalara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@Deblintrake09 Deblintrake09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The change itself it is not breaking as it is only used in two modules that are currently deprecated:

  • qa_docs.py
  • api_simulator.py

Copy link
Member

@juliamagan juliamagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

urllib3 is not only imported with:

import urllib3

It can also be from. If we look for this, several tests are affected, since it is used to disable warnings for API requests. This affects e2e tests, api tests, authd tests, logcollector tests and remoted tests. Please, let's run these tests to make 100% sure that there is no problem.

@jnasselle
Copy link
Member Author

Update

@Rebits launch the IT launcher tests on this branch and went well https://ci.wazuh.info/job/Test_integration_launcher/137

As @juliamagan mentioned, we will work on testing on every possible affected test

@BelenValdivia
Copy link
Contributor

LGTM
After executing the Integration tests the change does not affect the previous behavior of the tests.
Regarding the e2e tests, at the moment I do not consider it to be blocking because 100% of the integration tests were not affected by the change in the urllib3 version limitation.

@Rebits Rebits dismissed juliamagan’s stale review May 16, 2023 16:52

TIs have been found to be stable with this change.

@damarisg damarisg merged commit 62c9aeb into 4.4 May 16, 2023
@damarisg damarisg deleted the 5074-limit-urllib3-required-version branch May 16, 2023 16:55
jnasselle pushed a commit that referenced this pull request May 16, 2023
jnasselle added a commit that referenced this pull request May 16, 2023
damarisg pushed a commit that referenced this pull request May 16, 2023
jnasselle added a commit that referenced this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Required urllib3 could break the code on new 2.0.0 version
7 participants