Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Audit Buffer IT support #4227

Closed
wants to merge 27 commits into from
Closed

Add Audit Buffer IT support #4227

wants to merge 27 commits into from

Conversation

Deblintrake09
Copy link
Contributor

@Deblintrake09 Deblintrake09 commented Jun 5, 2023

Related issue
#3963

Description

This Issue aims to add IT support for the new Audit whodata buffer. This is managed by the whodata->queue_size tag that limits the amount of audit events that are received by syscheck. When the queue is full, events are dropped and the files modification are detected through scheduled mode instead of whodata.

Added

  • test_audit_buffer_configuration.py module containing 7 cases related to queue_size configuration values
  • test_audit_buffer_behavior.py module containing 2 cases related to queue_size basic behavior
  • test_audit_buffer_over_time.py module containing 2 cases related to queue_size's behavior in relation to max_eps
  • Added new callbacks and functions

Changed

  • refactored test_file_limit's conf file to different files to avoid duplicated and skipped cases

Testing performed

Tester Test path Jenkins Local OS Commit Notes
@Deblintrake09 (Developer) 🟢🟢🟢 🟢🟢🟢 Manager 7fae44c Nothing to highlight
@Deblintrake09 (Developer) 🟢🟢🟢 🔵 Linux Agent 7fae44c Nothing to highlight
@Deblintrake09 (Developer) 🟢🟢🟢 🟢🟢🟢 Windows Agent 7fae44c Nothing to highlight
@Deblintrake09 (Developer) 🟢🟢🟢 🚫 Solaris & macOS Agent f13f4c5 Nothing to highlight

@Deblintrake09 Deblintrake09 linked an issue Jun 5, 2023 that may be closed by this pull request
@pytest.mark.parametrize('test_folders', [test_folders], ids='', scope='module')
@pytest.mark.parametrize('configuration, metadata', zip(t2_configurations, t2_configuration_metadata),
ids=t2_test_case_ids)
def test_audit_buffer_overflown(configuration, metadata, test_folders, set_wazuh_configuration,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name was changed.

@Deblintrake09
Copy link
Contributor Author

Deblintrake09 commented Jun 9, 2023

Execution after requested changes

System Results Notes
Manager Centos 🟢
Agent Centos 🟢
Agent Windows 🟢

damarisg
damarisg previously approved these changes Jun 13, 2023
Copy link
Member

@juliamagan juliamagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could some tests be unified for simplification? For example, default and values could go in the same, and one of the values to test could be the default.

juliamagan
juliamagan previously approved these changes Jun 15, 2023
@Deblintrake09 Deblintrake09 changed the base branch from 4.6.0 to 4.7.0 August 3, 2023 18:35
@Deblintrake09 Deblintrake09 dismissed juliamagan’s stale review August 3, 2023 18:35

The base branch was changed.

@Deblintrake09
Copy link
Contributor Author

PR has unverified commits caused by changed Github key. They cannot be fixed due to merge commits, so is dropped. New PR #4399 has been created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants