Skip cases that uses the deprecated protocol TLS 1.1
#4229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damarisg
approved these changes
Jun 7, 2023
juliamagan
approved these changes
Jun 9, 2023
* feat(#3541): enhacement syscollector test * feat(#3541): added test cases * refactor(#3541): deleted old files * feat(#3541): added test cases folder * feat(#3541): added new description * fix(#3541): deleted space * fix(#3541): linter errors * fix(#3541): Fix changelog error * fix(#3451): deleted imports * fix(#3541): adapt cases to new expected payload * fix(#3541): style to docstrings and remove remaining print --------- Co-authored-by: quebim <[email protected]>
QU3B1M
force-pushed
the
4188-fix-openssl-errors
branch
from
e866e1e
to
f040899
Compare
damarisg
previously approved these changes
Jun 16, 2023
juliamagan
requested changes
Jun 19, 2023
QU3B1M
force-pushed
the
4188-fix-openssl-errors
branch
from
05d21f3
to
fa84f08
Compare
QU3B1M
force-pushed
the
4188-fix-openssl-errors
branch
from
4cdbf84
to
49b52ba
Compare
davidjiglesias
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The tests cases that use ssl protocol
TLS 1.1were failing, doing fast research I found thatTLS 1.1andTLS 1.2were deprecated some time ago, and using TLS 1.1 causes unexpected internal errors on the pythonssllibrary.First I tried to find a workaround to make
TLS 1.1work I didn't succeed, then I tried to run the cases only when the host system has installed a version ofOpenSSLwhere the protocols are still supported, but that took me a lot of time and I still wasn't sure the critearia was ok. So, after several hours doing research and testing, it was decided to skip theTLS 1.1cases until the refactor of the test scenario.Updated
test_authd/test_authd_ssl_options.pytest_authd/data/enroll_ssl_options_tests.yamlTesting performed
test_authd/test_authd_ssl_options.pyUbuntu 20.04test_authd/Ubuntu 20.04