Fix flaky test in AR suite (excecd) #4360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
damarisg
requested changes
Jul 26, 2023
tests/integration/test_active_response/test_execd/test_execd_firewall_drop.py
Show resolved
Hide resolved
mauromalara
force-pushed
the
fix-ar-execd-flaky-test
branch
from
6e9d4d4
to
cecd5f6
Compare
damarisg
approved these changes
Aug 2, 2023
|
All commits need to be signed. |
mauromalara
force-pushed
the
fix-ar-execd-flaky-test
branch
from
cecd5f6
to
cc0f2b2
Compare
This was referenced Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a block of code checking IP tables but the problem was that it failed to get the IP on time. So, it was a ""race condition"" between AR and the test trying to get the output of a command just in time.
Updated
tests/integration/test_active_response/test_execd/test_execd_firewall_drop.pytests/integration/test_active_response/test_execd/conftest.pyTesting performed