Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misspelling regex and error in test_cluster_connection #4392

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

roronoasins
Copy link
Contributor

@roronoasins roronoasins commented Aug 3, 2023

Related issue
#4391

Description

The test case where the connection pattern is searched, it is not well formatted.

Updated

  • test_cluster_connection Successfully connected to master pattern fixed
  • test_cluster_connection Successfully connected to master error message fixed
  • Update README
  • Fix some loggers info and debug level messages

These changes were tested with the artifacts within this issue #4386, so it fails as expected because the artifact generated had some errors.

        if disconnected_nodes:
>           pytest.fail(f'The following nodes disconnected from master at any point:\n- ' + '\n- '.join(disconnected_nodes))
E           Failed: The following nodes disconnected from master at any point:
E           - worker_3
E           - worker_1
E           - worker_2
E           - worker_24
E           - worker_21
E           - worker_22
E           - worker_23
E           - worker_11
E           - worker_20
E           - worker_9
E           - worker_15
E           - worker_17
E           - worker_18
E           - worker_14
E           - worker_12
E           - worker_4
E           - worker_10
E           - worker_7
E           - worker_25
E           - worker_6
E           - worker_13
E           - worker_8
E           - worker_5
E           - worker_19
E           - worker_16

Evidences

report_test_cluster.zip

@roronoasins roronoasins self-assigned this Aug 3, 2023
@roronoasins roronoasins linked an issue Aug 3, 2023 that may be closed by this pull request
@damarisg
Copy link
Member

The description should contains the evidence that this changes work succesfull.

@pro-akim
Copy link
Member

pro-akim commented Aug 24, 2023

Update

Report checked
Linter test failing but it is not related with new changed done in the PR.
LGTM

@davidjiglesias davidjiglesias merged commit 8908844 into 4.6.0 Sep 6, 2023
3 of 4 checks passed
@davidjiglesias davidjiglesias deleted the 4391-fix-test-cluster-connection branch September 6, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix misspelling bug in the test_cluster_connection
4 participants