Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip mark changes in FIM tests #4569

Merged
merged 4 commits into from
Oct 4, 2023
Merged

Skip mark changes in FIM tests #4569

merged 4 commits into from
Oct 4, 2023

Conversation

pro-akim
Copy link
Member

@pro-akim pro-akim commented Oct 3, 2023 •
edited
Loading

Related issue
#4557

Description

Changed

  • tests/integration/test_fim/test_registry/test_registry_basic_usage/test_basic_usage_delete_registry.py
  • tests/integration/test_fim/test_synchronization/test_registry_responses_win32.py

Change:

@pytest.mark.skip(sys.platform=='win32', reason="Blocked by #4077.")

to:

@pytest.mark.skipif(sys.platform=='win32', reason="Blocked by #4077.")

Testing performed

Tester Test path Jenkins Local OS Commit Notes
@pro-akim (Developer) 🟢🟢🟢 ⚫⚫⚫ Nothing to highlight
@user (Reviewer) ⚫⚫⚫ 🚫 🚫 🚫 Nothing to highlight

@pro-akim pro-akim linked an issue Oct 3, 2023 that may be closed by this pull request
Wrong skip marks in FIM tests #4557
Closed
@davidjiglesias davidjiglesias merged commit de9e19f into 4.6.0 Oct 4, 2023
4 checks passed
@davidjiglesias davidjiglesias deleted the bug/4557-FIM_skip_mark_fix branch October 4, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damarisg damarisg damarisg approved these changes

@davidjiglesias davidjiglesias davidjiglesias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong skip marks in FIM tests
3 participants
@pro-akim @damarisg @davidjiglesias