Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean environment between basic_cluster tests #4656

Merged
merged 6 commits into from
Oct 27, 2023

Conversation

juliamagan
Copy link
Member

@juliamagan juliamagan commented Oct 25, 2023

Related issue
#4617

Description

System tests currently do not follow a specific format, and many reuse environments, are dependent and leave the environments corrupted, so when launching the basic_cluster environment, it was necessary to do it in parts.

For this reason, in this PR we have introduced some fixes to avoid this problem. We have focused only on fixing them, but not on improving them, as these tests need a time consuming refactor, and will be deprecated soon.

Updated

  • Updated tests and fixtures to prepare and clean environments

Testing performed

Tester Test path Jenkins Local OS Commit Notes
@juliamagan (Developer) tests/system -m basic_cluster_env 🚫 🚫 🚫 🟢 🟢 🟢 cea5844 Nothing to highlight
@user (Reviewer) 🚫 🚫 🚫 🚫 🚫 🚫 Nothing to highlight

@juliamagan juliamagan self-assigned this Oct 25, 2023
@juliamagan juliamagan marked this pull request as ready for review October 25, 2023 15:47
Copy link
Member

@pro-akim pro-akim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Notes

LGTM

@davidjiglesias davidjiglesias merged commit f9d7baa into 4.7.0 Oct 27, 2023
4 checks passed
@davidjiglesias davidjiglesias deleted the bug/4617-clean-system-env branch October 27, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the basic cluster system tests that cannot be executed without modifications
3 participants