Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicated jq requirement #4678

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Fix duplicated jq requirement #4678

merged 3 commits into from
Nov 9, 2023

Conversation

Rebits
Copy link
Member

@Rebits Rebits commented Nov 6, 2023 •
edited
Loading

Related issue
#4679

Description

Updated

  • Fix duplicated jq requirement

Testing performed

Test Integration: https://ci.wazuh.info/job/Test_integration/44467/consoleFull

Note
Error not related with the development. Instances were correctly provisioned

Tests E2E System: https://ci.wazuh.info/job/Test_e2e_system/142/console

Note
E2E pipeline fails for different issue. It provision qa framework correctly

@Rebits Rebits linked an issue Nov 6, 2023 that may be closed by this pull request
Duplicate 'jq' Dependency Definitions for Python Versions < 3.11 #4679
Closed
@Rebits Rebits marked this pull request as ready for review November 6, 2023 09:32
@Rebits Rebits self-assigned this Nov 6, 2023
juliamagan
juliamagan previously approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@juliamagan juliamagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliamagan
juliamagan previously approved these changes Nov 6, 2023
View reviewed changes
davidjiglesias
davidjiglesias requested changes Nov 6, 2023
View reviewed changes
Copy link
Member

@davidjiglesias davidjiglesias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change condition to 3.10

@Rebits
Copy link
Member Author

Rebits commented Nov 6, 2023

Done here

@davidjiglesias davidjiglesias merged commit 244bf42 into 4.8.0 Nov 9, 2023
1 of 2 checks passed
@davidjiglesias davidjiglesias deleted the fix/jq-requirement branch November 9, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidjiglesias davidjiglesias davidjiglesias requested changes

@juliamagan juliamagan juliamagan left review comments

Assignees

@Rebits Rebits

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate 'jq' Dependency Definitions for Python Versions < 3.11
3 participants
@Rebits @davidjiglesias @juliamagan