Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated message from cluster System Tests #4740

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

Deblintrake09
Copy link
Contributor

Related issue
#4735

Description

After 4.7.0 an expected message was deprecated, causing test_cluster/test_agent_files_deletion/test_agent_files_deletion.py test to fail. This issue removes the deprecated message.

Updated

  • Updated test_cluster/test_agent_files_deletion/test_agent_files_deletion.py expected messages

Testing performed

# python3 -m pytest test_agent_files_deletion/test_agent_files_deletion.py --html=/home/deblintrake/Documents/Vagrant/test.html
====================================== test session starts ======================================
platform linux -- Python 3.10.12, pytest-7.1.2, pluggy-1.3.0
rootdir: /home/deblintrake/Documents/Vagrant/wazuh-qa/tests/system, configfile: pytest.ini
plugins: testinfra-5.0.0, metadata-3.0.0, html-3.1.1
collected 1 item                                                                                

test_agent_files_deletion/test_agent_files_deletion.py .                                  [100%]

----------- generated html file: file:///home/deblintrake/Documents/Vagrant/test.html -----------
================================= 1 passed in 272.26s (0:04:32) =================================


# python3 -m pytest test_agent_files_deletion/test_agent_files_deletion.py --html=/home/deblintrake/Documents/Vagrant/test2.html
====================================== test session starts ======================================
platform linux -- Python 3.10.12, pytest-7.1.2, pluggy-1.3.0
rootdir: /home/deblintrake/Documents/Vagrant/wazuh-qa/tests/system, configfile: pytest.ini
plugins: testinfra-5.0.0, metadata-3.0.0, html-3.1.1
collected 1 item                                                                                

test_agent_files_deletion/test_agent_files_deletion.py .                                  [100%]

---------- generated html file: file:///home/deblintrake/Documents/Vagrant/test2.html -----------
================================= 1 passed in 279.19s (0:04:39) =================================


# python3 -m pytest test_agent_files_deletion/test_agent_files_deletion.py --html=/home/deblintrake/Documents/Vagrant/test3.html
====================================== test session starts ======================================
platform linux -- Python 3.10.12, pytest-7.1.2, pluggy-1.3.0
rootdir: /home/deblintrake/Documents/Vagrant/wazuh-qa/tests/system, configfile: pytest.ini
plugins: testinfra-5.0.0, metadata-3.0.0, html-3.1.1
collected 1 item                                                                                

test_agent_files_deletion/test_agent_files_deletion.py .                                  [100%]

---------- generated html file: file:///home/deblintrake/Documents/Vagrant/test3.html -----------
================================= 1 passed in 218.19s (0:03:38) =================================

@Deblintrake09 Deblintrake09 changed the title fix: remove deprecated message Remove deprecated message from cluster System Tests Nov 30, 2023
@Deblintrake09 Deblintrake09 self-assigned this Nov 30, 2023
Copy link
Member

@QU3B1M QU3B1M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidjiglesias davidjiglesias merged commit 95f6b66 into 4.7.1 Dec 1, 2023
3 of 4 checks passed
@davidjiglesias davidjiglesias deleted the enhancement/4735-fix-system-cluster-tests branch December 1, 2023 07:23
@pro-akim pro-akim mentioned this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants