Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix control_service error handling #4741

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

Deblintrake09
Copy link
Contributor

@Deblintrake09 Deblintrake09 commented Dec 1, 2023

Related issue
closes #4733

Description

This PR enhances control_service function error handling on windows agents and prints the error in case an unexpected error is presented and the agent cannot be stopped or started.

Updated

  • wazuh_testing.tools.services.py

Testing performed

Tester Test path Jenkins Local OS Commit Notes
@Deblintrake09 (Developer) 🟢 ⚫⚫⚫ Nothing to highlight
@user (Reviewer) ⚫⚫⚫ 🚫 🚫 🚫 Nothing to highlight

@Deblintrake09 Deblintrake09 self-assigned this Dec 1, 2023
jnasselle
jnasselle previously approved these changes Dec 4, 2023
@Deblintrake09 Deblintrake09 changed the base branch from master to 4.7.1 December 5, 2023 09:57
@Deblintrake09 Deblintrake09 dismissed jnasselle’s stale review December 5, 2023 09:57

The base branch was changed.

@damarisg damarisg merged commit 921b09e into 4.7.1 Dec 7, 2023
4 of 5 checks passed
@damarisg damarisg deleted the enhancement/4733-control-service-error-handling branch December 7, 2023 13:15
@pro-akim pro-akim mentioned this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logcollector scanning IT: The ValueError was raised when attempting to stop the 'wazuh-logcollector' daemon
3 participants