Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix service tests to handle Python version-dependent issues by optimizing Ansible runner import strategy #4916

Merged
merged 5 commits into from
Feb 5, 2024

Conversation

Rebits
Copy link
Member

@Rebits Rebits commented Feb 5, 2024

Description

This PR includes a minor logic to avoid to ansible_runner module in the system module in case python version is less than 3.7

More information about the motivation of this change can be found in https:/wazuh/wazuh-jenkins/issues/6238#issuecomment-1927362809

Build: https://ci.wazuh.info/job/Test_service/7281/

Warning

This is only a temporal fix. We should troubleshoot this issue in the future creating a more flexible framework

@Rebits Rebits self-assigned this Feb 5, 2024
@Rebits Rebits marked this pull request as ready for review February 5, 2024 17:01
damarisg
damarisg previously approved these changes Feb 5, 2024
damarisg
damarisg previously approved these changes Feb 5, 2024
@damarisg
Copy link
Member

damarisg commented Feb 5, 2024

Approved. However, we are waiting for the results and Changelog file.

@damarisg damarisg merged commit e6632c9 into 4.8.0 Feb 5, 2024
3 of 4 checks passed
@damarisg damarisg deleted the fix/6238-service-tests-ansible-runner-import-error branch February 5, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants