Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-release and staging Filebeat module template URL #4950

Merged
merged 11 commits into from
Feb 19, 2024

Conversation

MARCOSD4
Copy link
Member

@MARCOSD4 MARCOSD4 commented Feb 12, 2024

Description

This PR aims to add the corresponding URLs for the filebeat module template when staging or pre-release packages are being utilized since it was discovered that the filebeat module consistently retrieves the filebeat template from the production environment.


Related issue: #4931

Testing performed

@MARCOSD4 MARCOSD4 marked this pull request as draft February 13, 2024 12:05
@Rebits Rebits force-pushed the enhancement/4931-change-filebeat-template-url branch from 2a9b696 to 242b1e7 Compare February 14, 2024 12:25
@Rebits Rebits marked this pull request as ready for review February 14, 2024 12:25
@Rebits Rebits linked an issue Feb 14, 2024 that may be closed by this pull request
@Rebits Rebits self-assigned this Feb 14, 2024
Copy link
Member

@juliamagan juliamagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ! Please add an entry with this change in the changelog.

…b.com:wazuh/wazuh-qa into enhancement/4931-change-filebeat-template-url
Copy link
Member

@juliamagan juliamagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should go in Fixed rather than Changed. Also, the issue is reported as a bug. Note also that we are filling the changelog from the bottom up.

juliamagan
juliamagan previously approved these changes Feb 15, 2024
Copy link
Member

@juliamagan juliamagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidjiglesias davidjiglesias merged commit 73e2c83 into 4.8.0 Feb 19, 2024
2 of 3 checks passed
@davidjiglesias davidjiglesias deleted the enhancement/4931-change-filebeat-template-url branch February 19, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filebeat Provisioning Role Fetches Production Template Exclusively
4 participants