Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multigroups guess system test #5396

Merged
merged 3 commits into from
May 17, 2024
Merged

Conversation

juliamagan
Copy link
Member

@juliamagan juliamagan commented May 16, 2024

Related issue
#5395

Description

A 10 second wait has been added so that the agent has time to send a first keep alive and be assigned the default group.


Testing performed

Validation Jenkins Local Commit Notes
tests/system -m enrollment_cluster_env 🚫 🟢 00cf84f Nothing to highlight

@juliamagan juliamagan self-assigned this May 16, 2024
@juliamagan juliamagan linked an issue May 16, 2024 that may be closed by this pull request
@juliamagan juliamagan marked this pull request as ready for review May 17, 2024 10:54
rafabailon
rafabailon previously approved these changes May 17, 2024
Copy link
Member

@rafabailon rafabailon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rauldpm rauldpm merged commit e62180d into 4.8.0 May 17, 2024
1 of 2 checks passed
@rauldpm rauldpm deleted the bug/5395-fix-multigroup-guess branch May 17, 2024 15:10
Copy link
Member

@rauldpm rauldpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rauldpm
Copy link
Member

rauldpm commented May 17, 2024

I don't know why the approval has not been generated before the merge, but I approved it previously

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multigroup guess system test is failing in 4.8.0 RC 2
3 participants