Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded references to branch in provision playbooks #5517

Merged
merged 30 commits into from
Jul 1, 2024

Conversation

santipadilla
Copy link
Member

@santipadilla santipadilla commented Jun 20, 2024

Closing/Related Issue

Closes #5509

Description

Removal of the hardcoded references to branch in provision playbooks for E2E tests.

Tasks

  • Remove any hardcoded references in the provision modules in the QA repository

@santipadilla santipadilla self-assigned this Jun 20, 2024
@santipadilla santipadilla linked an issue Jun 20, 2024 that may be closed by this pull request
3 tasks
@santipadilla santipadilla marked this pull request as ready for review June 26, 2024 12:25
@santipadilla santipadilla marked this pull request as draft June 26, 2024 12:26
@santipadilla santipadilla marked this pull request as ready for review June 26, 2024 15:24
Copy link
Member

@Rebits Rebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still hardcoded references in the QA provisioning methods:

Please review all hardcoded references and implement one of the following approaches:

  • Remove unnecessary repository installation tasks that rely on variables with default hardcoded versions (since the E2E pipeline exclusively uses custom packages).
  • Replace hardcoded versions with a new parameter.

Rebits
Rebits previously approved these changes Jun 28, 2024
Copy link
Member

@Rebits Rebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@juliamagan juliamagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juliamagan juliamagan merged commit 80ad6d5 into 4.8.1 Jul 1, 2024
0 of 2 checks passed
@juliamagan juliamagan deleted the enhancement/5509-remove-hardcoded-branch-references branch July 1, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove hardcoded references to branch in provision playbooks for E2E tests
3 participants