Fix SID syntax for group membership changes #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SIDs in logs from Active Directory are not contained within curly brackets, nor are they prefixed with a %. Perhaps this is from old NT days. This is an example log: 2018 Mar 01 00:00:00 WinEvtLog: Security: AUDIT_SUCCESS(4728): Microsoft-Windows-Security-Auditing: (no user): no domain: domaincontroller.lan.local: A member was added to a security-enabled global group. Subject: Security ID: S-1-5-21-0000000000-0000000000-000000000-00012 Account Name: admin_account Account Domain: LAN Logon ID: 0x11cc0174 Member: Security ID: S-1-5-21-0000000000-000000000-000000000-00675 Account Name: CN=added_account,OU=lan,DC=lan,DC=local Group: Security ID: S-1-5-21-0000000000-0000000000-000000000-512 Group Name: Domain Admins Group Domain: LAN Additional Information: Privileges: - Retaining old syntax and added fixed syntax as an OR regex.
|
As commented here: https://groups.google.com/forum/#!topic/wazuh/ivHtXyuxDxo In other languages, the field |
|
Thanks for your contribution @jjrbg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SIDs in logs from Active Directory are not contained within curly brackets, nor are they prefixed with a %. Perhaps this is from old NT days. This is an example log:
2018 Mar 01 00:00:00 WinEvtLog: Security: AUDIT_SUCCESS(4728): Microsoft-Windows-Security-Auditing: (no user): no domain: domaincontroller.lan.local: A member was added to a security-enabled global group. Subject: Security ID: S-1-5-21-0000000000-0000000000-000000000-00012 Account Name: admin_account Account Domain: LAN Logon ID: 0x11cc0174 Member: Security ID: S-1-5-21-0000000000-000000000-000000000-00675 Account Name: CN=added_account,OU=lan,DC=lan,DC=local Group: Security ID: S-1-5-21-0000000000-0000000000-000000000-512 Group Name: Domain Admins Group Domain: LAN Additional Information: Privileges: -
Retaining old syntax and added fixed syntax as an OR regex.