-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Microsoft Antimalware and Eventlog rules' channels #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristgl
changed the title
Fix Microsoft Antimalware and Eventlog rules channels
Fix Microsoft Antimalware and Eventlog rules' channels
May 15, 2019
Testing for each channel and provider nameThis testing shows alerts taking into account the changes made in this PR and the modifications for the issue #401.
|
snaow
approved these changes
May 15, 2019
chemamartinez
approved these changes
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes: #396
The rule 60007 was not filtering by the right channel. It has been changed to filter by
Security
, asMicrosoft-Windows-Eventlog
is the provider name.Also, rule 60008 has been changed for the same reason. A
Security Essentials
event looks like this:The channel is
System
and the provider name isMicrosoft Antimalware
.These rules' filtering fields and parent rule have been changed for the right ones.