Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unexpected Windows rules #771

Merged
merged 3 commits into from
Oct 28, 2020
Merged

Remove unexpected Windows rules #771

merged 3 commits into from
Oct 28, 2020

Conversation

chemamartinez
Copy link
Contributor

Hi team,

This PR fixes wazuh/wazuh#6407.

Wazuh v4.0.0 contains Windows rules for EventChannel incompatible with the official ones described at https://documentation.wazuh.com/4.0/user-manual/capabilities/log-data-collection/how-to-collect-wlogs.html#windows-ruleset-redesign.

Once the extra rules have been removed, the Windows events match as expected.

@chemamartinez chemamartinez added bug rules Rules related issues windows labels Oct 27, 2020
@chemamartinez chemamartinez self-assigned this Oct 27, 2020
@chemamartinez chemamartinez marked this pull request as ready for review October 27, 2020 18:17
@chemamartinez
Copy link
Contributor Author

I ran the tests manually and they pass as expected.

The pipeline is failing due to the bump version, which makes the manager's package not be found.

Copy link
Contributor

@bah07 bah07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug rules Rules related issues windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants