-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate the timeout setting #1303
Labels
type/bug
Bug issue
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
It's required to ensure that the timeout setting is on a valid state, this is, strictly greater than zero at least.
It's possible to set a zero or even negative value, which might set the application on an unuseful state. Fortunately, this is not happening as the Requests library already takes care of validating that no invalid timeout is used, but we need no enforce these checks on our side too, for a better UX and reliability.
This setting can be set either on the WUI, on the Configuration section, or directly on the configuration file, at /default/config.conf
In order to harden the App, this (and preferably every setting) must be validated on the frontend and on the backend.
Steps to reproduce
Settings > Configuration
Screenshots
The text was updated successfully, but these errors were encountered: