Fix client side basic auth #1622
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds `http_basic_auth` to the list of settings to cache for a session. That's a general requirement for basic auth to work for any downloader.
This commit explicitly adds basic auth to request header instead of passing `username` and `password` to wininet.InternetConnectW(). The reason is simple: The latter doesn't work. Passing username and password seems to have no effect on Windows 11. As a result github limits API calls to 60 per hour. With this change 5000 are applicable. That's an important change in case a custom repository is used rather than packagecontrol.io channel.
|
Already part of PC4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs related with basic authentication:
http_basic_authsetting is not cached by PackageManager and therefore not passed to downloaders.As a result users with numerous custom repositories might quickly hit rather low API rate limits.