Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix treatment of unmanaged libraries #1680

Merged
merged 4 commits into from
May 25, 2024
Merged

Conversation

deathaxe
Copy link
Collaborator

This PR...

  1. fixes INSTALLER not being added when installing wheels
  2. auto-fixes missing INSTALLER file at startup
    It affects only non-manipulated libraries. Manually removing INSTALLER still marks a package unmaintained as expected.
  3. avoid duplicate filesystem traversals to determine managed packages

This commit creates a list of orphaned managed libraries by checking each
libraries installer via InstalledLibrary object model instead of performing
filesystem traversal twice (to subtract unmanaged ones).
This commit makes sure not to upgrade unmanaged libraries.
... for better readability of debug logs.
This commit ensures to add <libname>.dist-info/INSTALLER and related RECORD
entry to mark installed WHEELS as managed.
@deathaxe deathaxe merged commit 589ef0d into master May 25, 2024
8 checks passed
@deathaxe deathaxe deleted the fix/unmanaged-libraries branch May 25, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant