Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subtotal rows to sections on Interop page #3004

Merged
merged 4 commits into from
Oct 26, 2022
Merged

Conversation

DanielRyanSmith
Copy link
Contributor

@DanielRyanSmith DanielRyanSmith commented Oct 19, 2022

See web-platform-tests/interop#205

This change renders a subtotal row under each table section on the Interop page.
Screen Shot 2022-10-19 at 10 24 56 AM

Interop years with only 1 table section will not render a subtotal row (2021 for example).
Screen Shot 2022-10-19 at 10 35 14 AM

@KyleJu
Copy link
Collaborator

KyleJu commented Oct 20, 2022

See web-platform-tests/interop#205

This change renders a subtotal row under each table section on the Interop page. Screen Shot 2022-10-19 at 10 24 56 AM

Interop years with only 1 table section will not render a subtotal row (2021 for example). Screen Shot 2022-10-19 at 10 35 14 AM

Should the Grand Total align to the left?

webapp/components/interop.js Outdated Show resolved Hide resolved
webapp/components/interop.js Outdated Show resolved Hide resolved
@KyleJu
Copy link
Collaborator

KyleJu commented Oct 20, 2022

This PR fixes #3006

@DanielRyanSmith DanielRyanSmith merged commit 34baedf into main Oct 26, 2022
@DanielRyanSmith DanielRyanSmith deleted the interop-subtotals branch October 26, 2022 15:18
@DanielRyanSmith DanielRyanSmith restored the interop-subtotals branch October 26, 2022 15:18
@DanielRyanSmith DanielRyanSmith deleted the interop-subtotals branch October 26, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants