Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make is:tentative match tentative directories #4048

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

gsnedders
Copy link
Member

Per https://web-platform-tests.org/writing-tests/file-names.html, tentative can be set at a directory level via the directory being called "tentative".

https://wpt.fyi/results/css/css-borders?label=master&label=experimental&aligned&q=is%3Atentative notably misses the entire "tentative" directory.

@gsnedders
Copy link
Member Author

The go_test regression is:

# github.com/web-platform-tests/wpt.fyi/api/query/cache/index [github.com/web-platform-tests/wpt.fyi/api/query/cache/index.test]
api/query/cache/index/index_filter_test.go:1073:8: duplicate field name Test in struct literal
api/query/cache/index/index_filter_test.go:1074:16: duplicate field name LegacyStatus in struct literal
api/query/cache/index/index_filter_test.go:1082:8: duplicate field name Test in struct literal
api/query/cache/index/index_filter_test.go:1083:16: duplicate field name LegacyStatus in struct literal
FAIL	github.com/web-platform-tests/wpt.fyi/api/query/cache/index [build failed]

I seem to have messed up committing my code after gofmt and broken it after I ran the tests, whoops.

And then web_components_test fails because of #4046.

Per https://web-platform-tests.org/writing-tests/file-names.html,
tentative can be set at a directory level via the directory being
called "tentative".
@past past closed this Oct 14, 2024
@past past reopened this Oct 14, 2024
@past past merged commit 6366c4a into web-platform-tests:main Oct 14, 2024
22 of 23 checks passed
@gsnedders gsnedders deleted the is-tentative-directory branch October 15, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants