location.pathname should return "blank" when there is no browsing con… #13854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…text The pathname of "about:blank" is "blank", not "".
cdumez
requested review from
annevk and
domenic
and removed request for
annevk
domenic
approved these changes
Nov 1, 2018
There was a problem hiding this comment.
This looks correct to me per https://jsdom.github.io/whatwg-url/#url=YWJvdXQ6Ymxhbms=&base=YWJvdXQ6Ymxhbms= ; sorry for missing it while reviewing.
kisg
pushed a commit
to paul99/webkit-mips
that referenced
this pull request
Nov 1, 2018
https://bugs.webkit.org/show_bug.cgi?id=191060 Reviewed by Geoffrey Garen. LayoutTests/imported/w3c: * web-platform-tests/html/browsers/history/the-location-interface/no-browsing-context.window-expected.txt: Rebase WPT test now that all checks are passing. * web-platform-tests/html/browsers/history/the-location-interface/no-browsing-context.window.js: Fix bug in WPT test (web-platform-tests/wpt#13854) * web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url.window-expected.txt: Source/WebCore: As per whatwg/html#4076, a Location object's URL should be "about:blank" when it does not have a browsing context (Frame), not "". No new tests, rebaselined existing tests. * page/Location.cpp: (WebCore::Location::url const): (WebCore::Location::href const): (WebCore::Location::protocol const): (WebCore::Location::host const): (WebCore::Location::hostname const): (WebCore::Location::port const): (WebCore::Location::pathname const): (WebCore::Location::search const): (WebCore::Location::origin const): (WebCore::Location::hash const): LayoutTests: Update existing tests to reflect behavior change. * http/tests/dom/same-origin-detached-window-properties-expected.txt: * http/tests/dom/same-origin-detached-window-properties.html: * http/tests/security/xss-DENIED-script-inject-into-inactive-window.html: * http/tests/security/xss-DENIED-script-inject-into-inactive-window2-pson.html: * http/tests/security/xss-DENIED-script-inject-into-inactive-window2.html: * http/tests/security/xss-DENIED-script-inject-into-inactive-window3.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@237702 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ryanhaddad
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Dec 22, 2020
https://bugs.webkit.org/show_bug.cgi?id=191060 Reviewed by Geoffrey Garen. LayoutTests/imported/w3c: * web-platform-tests/html/browsers/history/the-location-interface/no-browsing-context.window-expected.txt: Rebase WPT test now that all checks are passing. * web-platform-tests/html/browsers/history/the-location-interface/no-browsing-context.window.js: Fix bug in WPT test (web-platform-tests/wpt#13854) * web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url.window-expected.txt: Source/WebCore: As per whatwg/html#4076, a Location object's URL should be "about:blank" when it does not have a browsing context (Frame), not "". No new tests, rebaselined existing tests. * page/Location.cpp: (WebCore::Location::url const): (WebCore::Location::href const): (WebCore::Location::protocol const): (WebCore::Location::host const): (WebCore::Location::hostname const): (WebCore::Location::port const): (WebCore::Location::pathname const): (WebCore::Location::search const): (WebCore::Location::origin const): (WebCore::Location::hash const): LayoutTests: Update existing tests to reflect behavior change. * http/tests/dom/same-origin-detached-window-properties-expected.txt: * http/tests/dom/same-origin-detached-window-properties.html: * http/tests/security/xss-DENIED-script-inject-into-inactive-window.html: * http/tests/security/xss-DENIED-script-inject-into-inactive-window2-pson.html: * http/tests/security/xss-DENIED-script-inject-into-inactive-window2.html: * http/tests/security/xss-DENIED-script-inject-into-inactive-window3.html: Canonical link: https://commits.webkit.org/205976@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237702 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…text
The pathname of "about:blank" is "blank", not "".