Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for directionality and shadow DOM #29820

Merged
merged 28 commits into from
Oct 6, 2023
Merged

Tests for directionality and shadow DOM #29820

merged 28 commits into from
Oct 6, 2023

Commits on Oct 6, 2023

  1. Tests for :dir() and shadow DOM from issue web-platform-tests#3699

    @meyerweb @annevk
    meyerweb authored and annevk committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    8413b5d View commit details
    Browse the repository at this point in the history

  2. Moved tests from /css to /shadow-dom

    @meyerweb @annevk
    meyerweb authored and annevk committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    e1bc0bb View commit details
    Browse the repository at this point in the history

  3. git rm css/css-scoping/dir-shadow/

    @meyerweb @annevk
    meyerweb authored and annevk committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    29065a8 View commit details
    Browse the repository at this point in the history

  4. Removed errant tabs from dir-shadow.32.html

    @meyerweb @annevk
    meyerweb authored and annevk committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    24f8e36 View commit details
    Browse the repository at this point in the history

  5. Updated tests to remove CSS reliance

    @meyerweb @annevk
    meyerweb authored and annevk committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    7e745c1 View commit details
    Browse the repository at this point in the history

  6. Updates to tests 36-38 clarifying direction on nodes and contents

    @meyerweb @annevk
    meyerweb authored and annevk committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    87fb95d View commit details
    Browse the repository at this point in the history

  7. Moved original test run to v001

    @meyerweb @annevk
    meyerweb authored and annevk committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    037bc08 View commit details
    Browse the repository at this point in the history

  8. Restored reftests, removed testharness

    @meyerweb @annevk
    meyerweb authored and annevk committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    7799c4b View commit details
    Browse the repository at this point in the history

  9. Tweaked test 29

    @meyerweb @annevk
    meyerweb authored and annevk committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    0d0a74b View commit details
    Browse the repository at this point in the history

  10. Added test 41 for auto-dir slot with no content

    @meyerweb @annevk
    meyerweb authored and annevk committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    245e97a View commit details
    Browse the repository at this point in the history

  11. Added test 41 for auto-dir slot with no content

    @meyerweb @annevk
    meyerweb authored and annevk committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    2c1acb3 View commit details
    Browse the repository at this point in the history

  12. Added test 41 for auto-dir slot with no content

    @meyerweb @annevk
    meyerweb authored and annevk committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    402332e View commit details
    Browse the repository at this point in the history

  13. Added test 41 for auto-dir slot with no content

    @meyerweb @annevk
    meyerweb authored and annevk committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    bd7a5a5 View commit details
    Browse the repository at this point in the history

  14. Fixed test 41

    @meyerweb @annevk
    meyerweb authored and annevk committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    7cbb809 View commit details
    Browse the repository at this point in the history

  15. Fixed test 38

    @meyerweb @annevk
    meyerweb authored and annevk committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    5a9b5a9 View commit details
    Browse the repository at this point in the history

  16. First draft of language handling tests

    @meyerweb @annevk
    meyerweb authored and annevk committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    ed99cdf View commit details
    Browse the repository at this point in the history

  17. Sync expections basedon web-platform-tests#29820 (comment)

    @bkardell @annevk
    bkardell authored and annevk committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    49be516 View commit details
    Browse the repository at this point in the history

  18. Add periods where relevant as that is part of the rendering we need t… 

    …o test
    @bkardell @annevk
    bkardell authored and annevk committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    5d84263 View commit details
    Browse the repository at this point in the history

  19. Correct dir-shadow-31-ref.html . 

    This change matches the behavior of Chromium, Gecko, and WebKit.

I believe this is correct because in the test, the dir attribute is on a
slot that has display: contents.  Therefore there is nothing that
establishes a new bidi embedding.

(This could also be fixed by just removing the dir attribute, but I
think this fix is slightly clearer.)
    @dbaron @annevk
    dbaron authored and annevk committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    a38a347 View commit details
    Browse the repository at this point in the history

  20. Move tests to html/dom/elements/global-attributes/. 

    Per @annevk's comment in
web-platform-tests#29820 (comment)
this moves all of the tests into html/dom/elements/global-attributes/,
drops the directionality/ subdirectory for some of them, and renames the
new lang-attribute-* to lang-attribute-shadow-*.
    @dbaron @annevk
    dbaron authored and annevk committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    a7a7745 View commit details
    Browse the repository at this point in the history

  21. Change expectation for dir-shadow-036.html. 

    This changes the expectation for dir-shadow-036.html as described in
web-platform-tests#29820 (comment) .

Based on the proposal in whatwg/html#3699 (comment) which says:
> dir=auto on a slot resolves against its slotted content.
I believe the expectation for this test should be changed to "ltr" for
both halves.  This matches test 006 which I think tests the same
behavior, rather than contradicting it.
    @dbaron @annevk
    dbaron authored and annevk committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    4a7db82 View commit details
    Browse the repository at this point in the history

  22. Add real rel=help links.

    @dbaron @annevk
    dbaron authored and annevk committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    d9c9fe2 View commit details
    Browse the repository at this point in the history

  23. Switch to more widely supported :lang() syntax since that's not the f… 

    …ocus of these tests.
    @dbaron @annevk
    dbaron authored and annevk committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    1ea8cb7 View commit details
    Browse the repository at this point in the history

  24. Add references for lang-attribute-shadow-* tests.

    @dbaron @annevk
    dbaron authored and annevk committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    5d64cd3 View commit details
    Browse the repository at this point in the history

  25. Better <title> elements, based on initial paragraphs.

    @dbaron @annevk
    dbaron authored and annevk committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    587ea30 View commit details
    Browse the repository at this point in the history

  26. Also test HTML direction with Element.matches().

    @dbaron @annevk
    dbaron authored and annevk committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    d3372b5 View commit details
    Browse the repository at this point in the history

  27. Fix confusing test descriptions.

    @dbaron @annevk
    dbaron authored and annevk committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    17f7f25 View commit details
    Browse the repository at this point in the history

  28. Drop lang attribute tests in favor of web-platform-tests#42364.

    @dbaron @annevk
    dbaron authored and annevk committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    c91b9c9 View commit details
    Browse the repository at this point in the history