Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make navigation-api/ tests resilient to starting with extra NavigationHistoryEntries #42232

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 28, 2023

When WPT are run in-browser or via wptrunner, there may be additional
session history entries when the test starts, so the tests shouldn't
assume that they start with navigation.entries().length == 1 or
navigation.currentEntry.index == 0.

This fixes all directories except navigate-event/ and
navigation-methods/, which had enough tests to deserve separate
treatment.

This is a workaround for #33590.

Change-Id: Ic60de8ffe247b374ef3a0e0939fc4c1a3427c7e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4903245
Auto-Submit: Nate Chapin <[email protected]>
Commit-Queue: Nate Chapin <[email protected]>
Reviewed-by: Domenic Denicola <[email protected]>
Reviewed-by: Weizhong Xia <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1204873}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-4903245 branch 2 times, most recently from 8e3ea02 to 165967d Compare October 3, 2023 20:54
…nHistoryEntries

When WPT are run in-browser or via wptrunner, there may be additional
session history entries when the test starts, so the tests shouldn't
assume that they start with navigation.entries().length == 1 or
navigation.currentEntry.index == 0.

This fixes all directories except navigate-event/ and
navigation-methods/, which had enough tests to deserve separate
treatment.

This is a workaround for #33590.

Change-Id: Ic60de8ffe247b374ef3a0e0939fc4c1a3427c7e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4903245
Auto-Submit: Nate Chapin <[email protected]>
Commit-Queue: Nate Chapin <[email protected]>
Reviewed-by: Domenic Denicola <[email protected]>
Reviewed-by: Weizhong Xia <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1204873}
@community-tc-integration
Copy link

Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/LsVGlbiwTseKkF-mV1pY7A/Gx6Rm3jMSUa0fKf_TCtcsQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/LsVGlbiwTseKkF-mV1pY7A"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/LsVGlbiwTseKkF-mV1pY7A/Gx6Rm3jMSUa0fKf_TCtcsQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/LsVGlbiwTseKkF-mV1pY7A"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2023-10-03T22:17:27.231Z

@community-tc-integration
Copy link

Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/LsVGlbiwTseKkF-mV1pY7A/Gx6Rm3jMSUa0fKf_TCtcsQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/LsVGlbiwTseKkF-mV1pY7A"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/LsVGlbiwTseKkF-mV1pY7A/Gx6Rm3jMSUa0fKf_TCtcsQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/LsVGlbiwTseKkF-mV1pY7A"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2023-10-03T22:26:15.647Z

@jonathan-j-lee
Copy link
Contributor

Looks like dispose-for-full-session-history.tentative.html is known to fail for Firefox in the same way (ReferenceError: navigation is not defined); this change is likely to be benign.

@KyleJu @DanielRyanSmith Admin merge? Thanks!

(@natechapin FYI: you can rerun the checks by closing and reopening the PR. Apparently it doesn't seem possible to remove the misleading "Re-run checks" button: #39458)

@DanielRyanSmith DanielRyanSmith merged commit 0a5ef44 into master Oct 5, 2023
19 of 21 checks passed
@DanielRyanSmith DanielRyanSmith deleted the chromium-export-cl-4903245 branch October 5, 2023 21:19
cookiecrook pushed a commit to cookiecrook/wpt that referenced this pull request Oct 11, 2023
…nHistoryEntries (web-platform-tests#42232)

When WPT are run in-browser or via wptrunner, there may be additional
session history entries when the test starts, so the tests shouldn't
assume that they start with navigation.entries().length == 1 or
navigation.currentEntry.index == 0.

This fixes all directories except navigate-event/ and
navigation-methods/, which had enough tests to deserve separate
treatment.

This is a workaround for web-platform-tests#33590.

Change-Id: Ic60de8ffe247b374ef3a0e0939fc4c1a3427c7e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4903245
Auto-Submit: Nate Chapin <[email protected]>
Commit-Queue: Nate Chapin <[email protected]>
Reviewed-by: Domenic Denicola <[email protected]>
Reviewed-by: Weizhong Xia <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1204873}

Co-authored-by: Nate Chapin <[email protected]>
Lightning00Blade pushed a commit to Lightning00Blade/wpt that referenced this pull request Dec 11, 2023
…nHistoryEntries (web-platform-tests#42232)

When WPT are run in-browser or via wptrunner, there may be additional
session history entries when the test starts, so the tests shouldn't
assume that they start with navigation.entries().length == 1 or
navigation.currentEntry.index == 0.

This fixes all directories except navigate-event/ and
navigation-methods/, which had enough tests to deserve separate
treatment.

This is a workaround for web-platform-tests#33590.

Change-Id: Ic60de8ffe247b374ef3a0e0939fc4c1a3427c7e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4903245
Auto-Submit: Nate Chapin <[email protected]>
Commit-Queue: Nate Chapin <[email protected]>
Reviewed-by: Domenic Denicola <[email protected]>
Reviewed-by: Weizhong Xia <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1204873}

Co-authored-by: Nate Chapin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants