URLSearchParams.prototype.sort() #4531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See whatwg/url#26 for context.
|
Notifying @Sebmaster, @domenic, @mikewest, @rubys, @sideshowbarker, @smola, @tomalec, @xiaojunwu, and @zcorpan. (Learn how reviewing works.) |
annevk
added a commit
to whatwg/url
that referenced
this pull request
Jan 12, 2017
This method is added to increase cache hits when making requests. It’s opt-in as the order of code points in a URL’s query is significant by default. It’s up to applications to decide if name order is not significant for them. Tests: web-platform-tests/wpt#4531. Fixes #26.
ChromeTesting revision 1a4a2cd All results/url/urlsearchparams-sort.html
|
FirefoxTesting revision 1a4a2cd All results/url/urlsearchparams-sort.html
|
domenic
reviewed
Jan 12, 2017
| "input": "\uFFFD=x&\uFFFC&\uFFFD=a", | ||
| "output": [["\uFFFC", ""], ["\uFFFD", "x"], ["\uFFFD", "a"]] | ||
| } | ||
| ].forEach((val) => { |
There was a problem hiding this comment.
I think we need at least a few tests on Unicode inputs, to show what type of sorting is being applied here. I assume it's just going to be by character code, so instead of sorting é near e, it'll sort after the usual alphabet? Tests to confirm.
|
What do you think? |
domenic
approved these changes
Jan 17, 2017
annevk
added a commit
to whatwg/url
that referenced
this pull request
Jan 18, 2017
This method is added to increase cache hits when making requests. It’s opt-in as the order of code points in a URL’s query is significant by default. It’s up to applications to decide if name order is not significant for them. Tests: web-platform-tests/wpt#4531. Fixes #26.
4 tasks
TimothyGu
added a commit
to TimothyGu/node
that referenced
this pull request
Feb 11, 2017
Fixes: nodejs#10760 Ref: whatwg/url#26 Ref: whatwg/url#199 Ref: web-platform-tests/wpt#4531
TimothyGu
added a commit
to nodejs/node
that referenced
this pull request
Feb 14, 2017
PR-URL: #11098 Fixes: #10760 Ref: whatwg/url#26 Ref: whatwg/url#199 Ref: web-platform-tests/wpt#4531 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
TimothyGu
added a commit
to nodejs/node
that referenced
this pull request
Feb 14, 2017
PR-URL: #11098 Fixes: #10760 Ref: whatwg/url#26 Ref: whatwg/url#199 Ref: web-platform-tests/wpt#4531 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
TimothyGu
added a commit
to TimothyGu/node
that referenced
this pull request
Feb 18, 2017
Backport-of: nodejs#11098 Fixes: nodejs#10760 Ref: whatwg/url#26 Ref: whatwg/url#199 Ref: web-platform-tests/wpt#4531
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 20, 2017
Backport-of: nodejs#11098 Fixes: nodejs#10760 Ref: whatwg/url#26 Ref: whatwg/url#199 Ref: web-platform-tests/wpt#4531
italoacasas
pushed a commit
to nodejs/node
that referenced
this pull request
Feb 22, 2017
Backport-of: #11098 Fixes: #10760 Ref: whatwg/url#26 Ref: whatwg/url#199 Ref: web-platform-tests/wpt#4531
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See whatwg/url#26 for context.