Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XMLHttpRequest: create more base URL tests #5863

Merged
merged 2 commits into from
May 15, 2017
Merged

Conversation

annevk
Copy link
Member

@annevk annevk commented May 9, 2017

No description provided.

@annevk
Copy link
Member Author

annevk commented May 9, 2017

Note: only Firefox passes all of these. But what Chrome and Safari do doesn't seem reasonable.

@ghost
Copy link

ghost commented May 9, 2017

View the complete job log.

Firefox (nightly channel)

Testing web-platform-tests at revision 6b12e55
Using browser at version BuildID 20170509100208; SourceStamp b21b974d60d3075ae24f6fb1bae75d0f122f28fc
Starting 10 test iterations
All results were stable

All results

1 test ran
/XMLHttpRequest/responsexml-document-properties.htm
Subtest Results Messages
OK
domain PASS
URL PASS
documentURI PASS
baseURI PASS
referrer PASS
title PASS
contentType PASS
readyState PASS
location PASS
defaultView PASS
body PASS
images PASS
doctype PASS
forms PASS
all PASS
links PASS
cookie FAIL assert_equals: expected (string) "" but got (undefined) undefined
Test document URL properties after redirect PASS
Test document URL properties of document with <base> after redirect PASS
lastModified set to time of response if no HTTP header provided PASS
lastModified set to related HTTP header if provided PASS
cookie (after setting it) FAIL assert_equals: expected "" but got "thisshouldbeignored"
styleSheets PASS
implementation PASS

@ghost
Copy link

ghost commented May 9, 2017

View the complete job log.

Chrome (unstable channel)

Testing web-platform-tests at revision 6b12e55
Using browser at version 60.0.3088.3 dev
Starting 10 test iterations
All results were stable

All results

1 test ran
/XMLHttpRequest/responsexml-document-properties.htm
Subtest Results Messages
OK
domain FAIL assert_equals: expected (undefined) undefined but got (string) "web-platform.test"
URL PASS
documentURI PASS
baseURI PASS
referrer PASS
title PASS
contentType PASS
readyState PASS
location PASS
defaultView PASS
body FAIL assert_equals: expected (undefined) undefined but got (object) null
images FAIL assert_equals: expected (undefined) undefined but got (object) object "[object HTMLCollection]"
doctype PASS
forms FAIL assert_equals: expected (undefined) undefined but got (object) object "[object HTMLCollection]"
all PASS
links FAIL assert_equals: expected (undefined) undefined but got (object) object "[object HTMLCollection]"
cookie PASS
Test document URL properties after redirect FAIL assert_equals: expected "http://web-platform.test:8000/XMLHttpRequest/resources/well-formed.xml" but got "http://web-platform.test:8000/XMLHttpRequest/resources/redirect.py?location=well-formed.xml"
Test document URL properties of document with <base> after redirect FAIL assert_equals: expected "http://web-platform.test:8000/XMLHttpRequest/resources/base.xml" but got "http://web-platform.test:8000/XMLHttpRequest/resources/redirect.py?location=base.xml"
lastModified set to time of response if no HTTP header provided PASS
lastModified set to related HTTP header if provided FAIL assert_equals: expected 1494341134000 but got 1494340935000;assert_equals: expected 1494341137000 but got 1494340935000;assert_equals: expected 1494341133000 but got 1494340935000;assert_equals: expected 1494341135000 but got 1494340935000;assert_equals: expected 1494341136000 but got 1494340935000;assert_equals: expected 1494341131000 but got 1494340935000;assert_equals: expected 1494341127000 but got 1494340935000;assert_equals: expected 1494341128000 but got 1494340935000;assert_equals: expected 1494341130000 but got 1494340935000;assert_equals: expected 1494341129000 but got 1494340935000
cookie (after setting it) PASS
styleSheets PASS
implementation PASS

@foolip
Copy link
Member

foolip commented May 9, 2017

@nyaxt @sof @tyoshino @yutakahirano, might any of you be interested in reviewing this and seeing if any of the Chrome failures are things that wouldn't be a good idea to change? (Adding yourselves to XMLHttpRequest/OWNERS in this repo is the way to keep track of all upstream changes before they are imported into Blink.)

@yutakahirano
Copy link
Contributor

Maybe https://crbug.com/379676?

@annevk
Copy link
Member Author

annevk commented May 10, 2017

@yutakahirano yeah, that seems like the basic issue from which all other problems derive.

@annevk
Copy link
Member Author

annevk commented May 10, 2017

@youennf thoughts?

@yutakahirano
Copy link
Contributor

OK, I fixed https://crbug.com/379676.

@annevk annevk merged commit e2d2cde into master May 15, 2017
@annevk annevk deleted the annevk/xhr-document-base branch May 15, 2017 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants