refactor: pr review

web3 · Sep 6, 2024 · 7361a79 · 7361a79
1 parent 00e231e
commit 7361a79
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 8 deletions.
diff --git a/packages/web3-eth/CHANGELOG.md b/packages/web3-eth/CHANGELOG.md
@@ -267,7 +267,7 @@ Documentation:
 ### Fixed
 
 - Adds transaction property to be an empty list rather than undefined when no transactions are included in the block (#7151)
-  w
+- Change method `getTransactionReceipt` to not be casted as `TransactionReceipt` to give proper return type (#7159)
 
 ## [Unreleased]
 

diff --git a/packages/web3-eth/src/rpc_method_wrappers.ts b/packages/web3-eth/src/rpc_method_wrappers.ts
@@ -296,7 +296,7 @@ export async function getBlock<ReturnFormat extends DataFormat>(
  const result = {
  ...res,
  transactions: res.transactions ?? [],
- };
+ }
  return result;
  }
 
@@ -530,11 +530,11 @@ export async function getTransactionReceipt<ReturnFormat extends DataFormat>(
  }
  return isNullish(response)
  ? response
- : format(
+ : (format(
  transactionReceiptSchema,
  response as unknown as TransactionReceipt,
  returnFormat ?? web3Context.defaultReturnFormat,
- );
+ ));
 }
 
 /**
@@ -579,7 +579,7 @@ export function sendTransaction<
  | TransactionWithFromAndToLocalWalletIndex,
  returnFormat: ReturnFormat,
  options: SendTransactionOptions<ResolveType> = { checkRevertBeforeSending: true },
- transactionMiddleware?: TransactionMiddleware,
+ transactionMiddleware?: TransactionMiddleware
 ): Web3PromiEvent<ResolveType, SendTransactionEvents<ReturnFormat>> {
  const promiEvent = new Web3PromiEvent<ResolveType, SendTransactionEvents<ReturnFormat>>(
  (resolve, reject) => {
@@ -592,9 +592,9 @@ export function sendTransaction<
  returnFormat,
  });
 
- let transaction = { ...transactionObj };
+ let transaction = {...transactionObj};
 
- if (!isNullish(transactionMiddleware)) {
+ if(!isNullish(transactionMiddleware)){
  transaction = await transactionMiddleware.processTransaction(transaction);
  }
 

diff --git a/packages/web3-eth/src/utils/decode_signed_transaction.ts b/packages/web3-eth/src/utils/decode_signed_transaction.ts
@@ -38,7 +38,6 @@ export function decodeSignedTransaction<ReturnFormat extends DataFormat>(
  returnFormat: ReturnFormat,
  options: { fillInputAndData?: boolean; transactionSchema?: ValidationSchemaInput } = {
  fillInputAndData: false,
- transactionSchema: undefined,
  },
 ): SignedTransactionInfoAPI {
  return {